Wayne Beaton wrote: > AFAICT, Eclipse Code Recommenders has been removed from the packages. I > do, however, see references to what I think look like references to > org.eclipse.recommenders.news.rcp bundle (optional) and extension point > in a couple of plugin.xml and MANIFEST files. Should these be removed?
that is not necessary. The News Feed bundle is optional and unrelated to the rest of Code Recommenders. Unfortunately, it is currently broken as the Feed Parser in Mylyn broke [1] with Java 11 (JAXB being removed). The feed declarations are still there to provide users who install the plugin from the Marketplace automatically are subscribed to the packages' feed. > We're very late in the process. Staging for the final RC is currently in > progress (the final build for RC2 starts at midnight EST). This feels > like too significant a change to commit after the final RC. > > I believe that we have three choices: > > 1) Stay in 2018-12 and contribute new bits > 2) Stay in 2018-12 and contribute the old bits > 3) Drop out of 2018-12 and remove the old bits > > I am I correct in assuming that the second option is actually invalid? I don't have a running build right now (and can't work full-time on this) so option 1 seems unlikely at this point; Java 11 simply broke to many things in our build. Under Java 11, option 2 logs several errors in the Error Log the first time the user triggers content assist in a Java file. Thereafter, JDT completion works as normal and Code Recommenders doesn't. To ensure that Java users have a smooth out-of-the-box experience, I personally would vote for option 3. > I think that we need a final call (from the Project Lead) right now. @Marcel: What's your take on this? Hope this helps. Andreas [1] <https://bugs.eclipse.org/bugs/show_bug.cgi?id=539681> -- Codetrails GmbH The best code possible Robert-Bosch-Str. 7, 64293 Darmstadt Mobile: +49-170-811-3791 http://www.codetrails.com/ Managing Director: Dr. Marcel Bruch Handelsregister: Darmstadt HRB 91940
signature.asc
Description: OpenPGP digital signature
_______________________________________________ cross-project-issues-dev mailing list [email protected] To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
