Hi Matthias As said, I would have suggested not to do that. I see it as minor inconsistency when looking at the whole IDE, but as long as EGit (or any other project) applies the same style in the whole project then I can live with it.
Dani From: "Becker, Matthias" <ma.bec...@sap.com> To: Cross project issues <cross-project-issues-dev@eclipse.org> Date: 25.09.2019 17:20 Subject: [EXTERNAL] Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Sent by: cross-project-issues-dev-boun...@eclipse.org Hi Dani, and what about the eGit tooling? The ?interactive rebase? view does use icons and text heavily (and I really like that). Does eGit *not* belong to the ?IDE? you are talking about? Is the ?interactive rebase? causing inconsistencies in the IDE? Or would you say that this is not an inconsistency? Regards, Matthias From: <cross-project-issues-dev-boun...@eclipse.org> on behalf of Daniel Megert <daniel_meg...@ch.ibm.com> Reply to: Cross project issues <cross-project-issues-dev@eclipse.org> Date: Wednesday, 25. September 2019 at 17:09 To: Cross project issues <cross-project-issues-dev@eclipse.org> Subject: Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Hi Matthias > "suboptimal UX". Like several others expressed, no icons are preferred and the standard on Windows and Linux. > Would ?advise against it but not -1?? What?s the difference between ?advise against? and ?-1?? Advise is giving an advice. Not give -1 means I would not block the contribution. Look at it as giving a 0. Dani From: "Becker, Matthias" <ma.bec...@sap.com> To: Cross project issues <cross-project-issues-dev@eclipse.org> Date: 25.09.2019 16:45 Subject: [EXTERNAL] Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Sent by: cross-project-issues-dev-boun...@eclipse.org Hi Dani, I understand your point. Then let?s say it in other words: Should new plugins stick to ?old? (and maybe suboptimal) UX because already existing plugins use suboptimal UX? What about a set of 3rd party plugins. Should it be allowed for them to decide to use icons on buttons in all their UIs? Would ?advise against it but not -1?? What?s the difference between ?advise against? and ?-1?? And what about the eGit tooling? The ?interactive rebase? view does use icons and text heavily (and I really like that). Does eGit *not* belong to the ?IDE? you are talking about? Regards, Matthias From: <cross-project-issues-dev-boun...@eclipse.org> on behalf of Daniel Megert <daniel_meg...@ch.ibm.com> Reply to: Cross project issues <cross-project-issues-dev@eclipse.org> Date: Wednesday, 25. September 2019 at 16:30 To: Cross project issues <cross-project-issues-dev@eclipse.org> Subject: Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Hi Matthias My main concern is consistency in the IDE. I don't think anyone would come forward to update the Plug-in Manifest editor for example. On the other hand if there is a new editor that consistently uses icons, I would still advise against it but not -1 it. Dani From: "Becker, Matthias" <ma.bec...@sap.com> To: Cross project issues <cross-project-issues-dev@eclipse.org> Date: 25.09.2019 15:57 Subject: [EXTERNAL] Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Sent by: cross-project-issues-dev-boun...@eclipse.org Hi Dani, yes I know that e.g. the Plug-in Manifest editor does only use text. But I question if it would not be better to use Icons (and/or Text) for such standard functions (for trees / tables) like ?Add?, ?Remove?, ?Up?, ?Down?. Regards, Matthias From: <cross-project-issues-dev-boun...@eclipse.org> on behalf of Daniel Megert <daniel_meg...@ch.ibm.com> Reply to: Cross project issues <cross-project-issues-dev@eclipse.org> Date: Wednesday, 25. September 2019 at 15:49 To: Cross project issues <cross-project-issues-dev@eclipse.org> Subject: Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Toolbars use icons without text. Within the part buttons usually only use text, see e.g. Plug-in Manifest editor. Dani From: "Becker, Matthias" <ma.bec...@sap.com> To: Cross project issues <cross-project-issues-dev@eclipse.org> Date: 25.09.2019 15:24 Subject: [EXTERNAL] Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Sent by: cross-project-issues-dev-boun...@eclipse.org Hi Dani, and what about view and editors? Regards, Matthias From: <cross-project-issues-dev-boun...@eclipse.org> on behalf of Daniel Megert <daniel_meg...@ch.ibm.com> Reply to: Cross project issues <cross-project-issues-dev@eclipse.org> Date: Wednesday, 25. September 2019 at 15:21 To: Cross project issues <cross-project-issues-dev@eclipse.org> Subject: Re: [cross-project-issues-dev] Text and / or Icons on Buttons / ToolbarItems Buttons in dialogs should use text and that's what you see in almost all our dialogs. It's also what Microsoft does in its dialogs (can't speak for Mac or Linux). -1 for using emojis. Dani From: "Becker, Matthias" <ma.bec...@sap.com> To: Cross project issues <cross-project-issues-dev@eclipse.org> Date: 25.09.2019 11:47 Subject: [EXTERNAL] [cross-project-issues-dev] Text and / or Icons on Buttons / Toolbar Items Sent by: cross-project-issues-dev-boun...@eclipse.org Dear Eclipse experts, today I had a discussion with co-workers and I also want your feedback on that topic. It?s about Text and/or Icons on (Standard) Buttons: Today we see a lot of dialogs in Eclipse where we have buttons that only have text but no icons. On example is Platforms ?Available Update Sites? preference page. There we have Add, Remove, Edit, ? on the right hand side of the table. Btw: Should the ?Edit? button not be ?Edit??? Also JDT?s ?Change Method Signature? refactoring dialog has a similar pattern: In contrast to that let?s have a look at the ?Rebase Interactive? view from EGIT: Here we also have buttons. But they all have icons and in addition they have text below the icons. I find the UI design of the interactive rebase view really good. The ?first time users? (that maybe don?t know the meaning of some icons) can directly read the text (and don?t need to hover with the mouse) and will (maybe) learn the icons. In addition there?s a context menu and we have key binding for the various actions. Let?s have a look at an additional location of icons and text. The perspective switcher: Here we also have Icons and text (but not on the right hand side) by default but the ?power user? can switch the text off. What?s the reason for not having icons on the other locations? The Add, Remove, Up, Down and Edit buttons could also get icons (that already either already exist in Eclipse or are known by ?everybody? from every day?s life). Regards, Matthias [attachment "image001.png" deleted by Daniel Megert/Zurich/IBM] [attachment "image002.png" deleted by Daniel Megert/Zurich/IBM] [attachment "image003.png" deleted by Daniel Megert/Zurich/IBM] [attachment "image004.png" deleted by Daniel Megert/Zurich/IBM] _______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev _______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
_______________________________________________ cross-project-issues-dev mailing list cross-project-issues-dev@eclipse.org To change your delivery options, retrieve your password, or unsubscribe from this list, visit https://www.eclipse.org/mailman/listinfo/cross-project-issues-dev
