[ 
https://issues.apache.org/jira/browse/CRUNCH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473435#comment-13473435
 ] 

Rahul Sharma commented on CRUNCH-93:
------------------------------------

The package contains 2 classes : 
 
1) InMemoryEmitter : This is used in MemPipeline, maybe we can move it to 
package o.a.c.impl.mem.emit which is something on line for emitters for MR 
pipeline

2) TestCounters : These are used in DoFns. I am not sure on this one but the 
clients are not supposed to use this class directly ? This is used in unit 
testing only as the context is not there. So shouldn't clients mock and provide 
a TaskInputOutputContext  ? or maybe we can create one in crunch-tests that the 
clients can use for junit testing ?

                
> Crunch core source should not contain packages like o.a.c.test 
> ---------------------------------------------------------------
>
>                 Key: CRUNCH-93
>                 URL: https://issues.apache.org/jira/browse/CRUNCH-93
>             Project: Crunch
>          Issue Type: Bug
>            Reporter: Rahul Sharma
>            Priority: Minor
>
> Crunch core has the following things a package named o.a.c.test and 
> TestCounters class.The source should not contain test package and classes 
> named with Test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to