[
https://issues.apache.org/jira/browse/CRUNCH-93?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473927#comment-13473927
]
Rahul Sharma commented on CRUNCH-93:
------------------------------------
For the Emitter, I think the primary purpose is in MemPipeline. But since it is
InMemory so clients can use it in unit tests, this is a side effect rather the
intended purpose. Thus I think that it should be in line with emitter for MR
pipelines eg. at package o.a.c.impl.mem.emit. This class will be available in
crunch-core and clients would be able to unit test their code using it.
As for TestCounters, I am thinking of creating a CrunchTestContext which will
contains things that are used for Junit tests eg overriding getCounters methods
and provide new TaskAttempID etc. Also move the TestCounters to crunch-test.
Clients can use them in JUnit tests in conjunction but they have to depend on
crunch-test
I see that both these things are important to unit testing of clients, may be
there are other things also which I am not aware of. If possible can we try to
move them to crunch-test as these classes provide unit testing support and are
not the core.
> Crunch core source should not contain packages like o.a.c.test
> ---------------------------------------------------------------
>
> Key: CRUNCH-93
> URL: https://issues.apache.org/jira/browse/CRUNCH-93
> Project: Crunch
> Issue Type: Bug
> Reporter: Rahul Sharma
> Priority: Minor
>
> Crunch core has the following things a package named o.a.c.test and
> TestCounters class.The source should not contain test package and classes
> named with Test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
