[
https://issues.apache.org/jira/browse/CRUNCH-122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Friedrich updated CRUNCH-122:
--------------------------------------
Description: There are a few implementation classes that are used only from
within their home package. Thus, they should be package-private instead of
public, which also hides them from javadoc. Most of these classes aren't from
our set of "published" packages anyway but it's good style to hide them if we
can. We can also make inner DoFns private if there is a static factory method
for them. (was: There are a few implementation classes that are used only from
within their home package. Thus, they should be package-private instead of
public, which also hides them from javadoc. Most of these classes aren't from
our set of "published" packages anyway but it's good style to hide them if we
can.)
Summary: Reduce visibility of implementation classes (was: Make
implementation classes package-private)
> Reduce visibility of implementation classes
> -------------------------------------------
>
> Key: CRUNCH-122
> URL: https://issues.apache.org/jira/browse/CRUNCH-122
> Project: Crunch
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Priority: Trivial
> Attachments: CRUNCH-122-Make-impl-classes-package-private.patch
>
>
> There are a few implementation classes that are used only from within their
> home package. Thus, they should be package-private instead of public, which
> also hides them from javadoc. Most of these classes aren't from our set of
> "published" packages anyway but it's good style to hide them if we can. We
> can also make inner DoFns private if there is a static factory method for
> them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
