[
https://issues.apache.org/jira/browse/CRUNCH-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508381#comment-13508381
]
Josh Wills commented on CRUNCH-122:
-----------------------------------
Looks good to me, w/the exception of SeqFileTableSource. That one surprised me,
and I discovered that it's not used outside of the package b/c we're return
SeqFileTableSourceTarget in the From.java code instead of SeqFileTableSource. I
think that is a bug, at least in so far as it is inconsistent w/the rest of the
Source stuff. It seems like the simplest fix would be to change From.java to
return SeqFileTableSource instead of SeqFileTableSourceTarget, but I'm happy to
have a debate on other options there.
> Reduce visibility of implementation classes
> -------------------------------------------
>
> Key: CRUNCH-122
> URL: https://issues.apache.org/jira/browse/CRUNCH-122
> Project: Crunch
> Issue Type: Improvement
> Affects Versions: 0.4.0
> Reporter: Matthias Friedrich
> Assignee: Matthias Friedrich
> Priority: Trivial
> Attachments: CRUNCH-122-Make-impl-classes-package-private.patch,
> CRUNCH-122-v2.patch
>
>
> There are a few implementation classes that are used only from within their
> home package. Thus, they should be package-private instead of public, which
> also hides them from javadoc. Most of these classes aren't from our set of
> "published" packages anyway but it's good style to hide them if we can. We
> can also make inner DoFns private if there is a static factory method for
> them.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
