What do you know, you're right! Thank you for finding the issue, and
proposing the fix.
Applied in the master.
On Tue, Jul 2, 2019 at 9:54 AM Andrew Wason <rectalo...@gmail.com> wrote:
>
> On Monday, July 1, 2019 at 9:58:12 PM UTC-4, Mouse wrote:
>>
>>
>> So, no - the above change does *not* look like a bug.
>>
>
>
> I don't think that change is the bug, the bug is that SymmetricEncrypt
> (and
> SymmetricDecrypt) did not also change to use MAC::DIGESTSIZE at the same
> time. It continues to use MAC::DEFAULT_KEYLENGTH
>
> Fixing that in master and it works properly with NULLHash:
>
> diff --git a/gfpcrypt.h b/gfpcrypt.h
> index 1b26a56b..f15c397e 100644
> --- a/gfpcrypt.h
> +++ b/gfpcrypt.h
> @@ -716,7 +716,7 @@ public:
> if (DHAES_MODE)
> {
> macKey = key;
> - cipherKey = key + MAC::DEFAULT_KEYLENGTH;
> + cipherKey = key + MAC::DIGESTSIZE;
> }
> else
> {
> @@ -748,7 +748,7 @@ public:
> if (DHAES_MODE)
> {
> macKey = key;
> - cipherKey = key + MAC::DEFAULT_KEYLENGTH;
> + cipherKey = key + MAC::DIGESTSIZE;
> }
> else
> {
>
>
>
> --
> You received this message because you are subscribed to "Crypto++ Users".
> More information about Crypto++ and this group is available at
> http://www.cryptopp.com and
> http://groups.google.com/forum/#!forum/cryptopp-users.
> ---
> You received this message because you are subscribed to the Google Groups
> "Crypto++ Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to cryptopp-users+unsubscr...@googlegroups.com.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/cryptopp-users/f9102d96-e126-44b1-b3f5-9aadb9d64016%40googlegroups.com
> <https://groups.google.com/d/msgid/cryptopp-users/f9102d96-e126-44b1-b3f5-9aadb9d64016%40googlegroups.com?utm_medium=email&utm_source=footer>
> .
>
--
Regards,
Mouse
--
You received this message because you are subscribed to "Crypto++ Users". More
information about Crypto++ and this group is available at
http://www.cryptopp.com and
http://groups.google.com/forum/#!forum/cryptopp-users.
---
You received this message because you are subscribed to the Google Groups
"Crypto++ Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to cryptopp-users+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/cryptopp-users/CA%2BFPB8MCuywL6PNSKrFpBUO1qwDWZiwn4%2ByX58LifeyjMNEE7A%40mail.gmail.com.
