On Wed 25 Jun 2014 at 18:43:40 -0500, Matthew D. Fuller wrote: > 1) Should we consider the #ifdef EWMH stuff as temporary? Certainly > it's sensible in dev to be able to flip it on and off. And maybe > through a full release cycle. But AIUI, this doesn't drag in any > extra libraries, or require support from the X server. If nothing > else but us knew anything about EWMH, all that would happen is we'd > waste a few cycles checking properties that aren't set, and setting > properties nobody else looks at.
That's indeed the case. I think I basically made it conditional because the GNOME stuff is conditional as well: just following the pattern. > If that's the case, I propose that once we've banged it around > enough to be confident it's no more buggy than any of the rest of > the code, we should plan to unifdef it and just have it > unconditional. That's fine with me. Unless we think that in 10 years there will be another different standard to follow perhaps ... > 2) I note that you're taking USE_EWMH as a signal to force USE_GNOME > off. Is that a "if both are enabled things will go screwy", a "we > do everything it does so it's completely subsumed anyway", or just > a "GNOME1 stuff is historical"? > It doesn't _seem_ to be the middle one, as they're poking around > different properties. I haven't formally checked yet but I aim to at least support everthing in EWMH that the GNOME1 code does. But they've renamed pretty much all properties that they use, even when they do more or less the same thing. So if you enable both, you're doing some stuff twice. And I have the impression that nothing looks at the GNOME1 properties any more so it's pretty much a waste of time. (That makes it a combination of the 2nd and 3rd ones) > If it's the latter, I'd as soon not mutex them, though a short > settling of EWMH may be the signal for shutting GNOME off by > default. If one can check whether a value was set by default or by the user, that's fine with me. (I'm off for a few days, so I wo't reply to emails for a bit) -Olaf. -- ___ Olaf 'Rhialto' Seibert -- The Doctor: No, 'eureka' is Greek for \X/ rhialto/at/xs4all.nl -- 'this bath is too hot.'
pgphHvG3rLTRY.pgp
Description: PGP signature
