On Mon, 22 Mar 2010 10:56:04 +0000 (UTC)
Peter Pentchev <r...@freebsd.org> mentioned:

> roam        2010-03-22 10:56:04 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     dns/c-ares           Makefile distinfo pkg-plist 
>     dns/c-ares/files     ares-config-info.patch patch-Makefile.in 
>   Log:
>   Update to c-ares-1.7.0.  In the process:
>   - actually pass the options-enabled arguments to the configure script!
>   - add the "hide symbols" configurable knob, though I've no idea why
>     anybody would want to turn that off... except maybe for debugging
>   - install the "acountry", "adig", and "ahost" programs, since they do
>     come in useful every now and then
>   - refresh the patches and add descriptions at the top
>   
>   Revision  Changes    Path
>   1.12      +16 -3     ports/dns/c-ares/Makefile
> http://cvsweb.FreeBSD.org/ports/dns/c-ares/Makefile.diff?r1=1.11&r2=1.12
> | --- ports/dns/c-ares/Makefile       2009/06/23 13:27:53     1.11
> | +++ ports/dns/c-ares/Makefile       2010/03/22 10:56:04     1.12
> | @@ -2,11 +2,11 @@
> |  # Date created:            8 September 2003
> |  # Whom:                    r...@freebsd.org
> |  #
> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/dns/c-ares/Makefile,v 
> 1.11 2009/06/23 13:27:53 pav Exp $
> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/dns/c-ares/Makefile,v 
> 1.12 2010/03/22 10:56:04 roam Exp $
> |  #
> |  
> |  PORTNAME=  c-ares
> | -PORTVERSION=       1.6.0
> | +PORTVERSION=       1.7.0
> |  CATEGORIES=        dns
> |  MASTER_SITES=      http://c-ares.haxx.se/
> |  
> | @@ -15,6 +15,7 @@ COMMENT=  An asynchronous DNS resolver li
> |  
> |  OPTIONS=   CONFIG_INFO     "Add the ares_config_info patch" ON \
> |             DEBUG           "Build with debug information" OFF \
> | +           HIDE_SYMBOLS    "Hide internal library symbols" ON \
> |             OPTIMIZED_CFLAGS        "Build with compiler optimizations" OFF
> |  
> |  CONFLICTS= ares-1.*
> | @@ -32,6 +33,11 @@ CONFIGURE_ARGS+= --enable-debug
> |  .else
> |  CONFIGURE_ARGS+=   --disable-debug
> |  .endif
> | +.if defined(WITH_HIDE_SYMBOLS)
> | +CONFIGURE_ARGS+=   --enable-symbol-hiding
> | +.else
> | +CONFIGURE_ARGS+=   --disable-symbol-hiding
> | +.endif

You have HIDE_SYMBOLS "on" by default, so the check should look like
.if !defined(WITHOUT_HIDE_SYMBOLS)

Otherwise the behaviour of the port is inconsistent wrt. to the batch builds.
Now the package built from the port include library symbols which is not 
default.

-- 
Stanislav Sedov
ST4096-RIPE

Attachment: pgpHnyITWJ1vu.pgp
Description: PGP signature

Reply via email to