Just out of curiosity, why has this discussion suddenly moved to <cygwin
at cygwin dot com> from <cygwin-apps at cygwin dot com>?
Igor
On Fri, 14 Feb 2003, Ralf Habacker wrote:
> > > > wasn't tight enough.
> > > >
> > > > My version:
> > > >
> > > > (char *)&relocp->SizeOfBlock < (char *)relocs + size
> > > >
> > > > seems to be.
> > > >
> > >
> > > What was the problem with this guard:
> >
> > To which guard are you referring? Mine or yours?
> >
> > > Does it not fix the last entry of a relocation block ?
> >
> > I'm concerned that my guard might have an off-by-one error and miss the
> > last entry. Is there an easy way to check this?
>
> I have compared this with, what objdump says and it seems there is no
> difference.
> I've checked in your changes additional with some debug informations printings
> in Relocations::check()
>
> Regards
> Ralf
On Fri, 14 Feb 2003, Jason Tishler wrote:
> Ralf,
>
> On Fri, Feb 14, 2003 at 02:42:40PM +0100, Ralf Habacker wrote:
> > > I'm concerned that my guard might have an off-by-one error and miss
> > > the last entry. Is there an easy way to check this?
> >
> > I have compared this with, what objdump says and it seems there is no
> > difference.
>
> I did some checking and arrived at the same conclusion.
>
> > I've checked in your changes additional with some debug informations
> > printings in Relocations::check()
>
> Thanks.
>
> I found another bug (most likely introduce by me in a previous patch)
> when rebasing up and the DLL is already based at the requested address.
> The attached patch is one way to correct this problem.
>
> Thanks,
> Jason
--
http://cs.nyu.edu/~pechtcha/
|\ _,,,---,,_ [EMAIL PROTECTED]
ZZZzz /,`.-'`' -. ;-;;,_ [EMAIL PROTECTED]
|,4- ) )-,_. ,\ ( `'-' Igor Pechtchanski
'---''(_/--' `-'\_) fL a.k.a JaguaR-R-R-r-r-r-.-.-. Meow!
Oh, boy, virtual memory! Now I'm gonna make myself a really *big* RAMdisk!
-- /usr/games/fortune
