On 10/03/2024 15:44, Christian Franke via Cygwin-apps wrote:
Jon Turney wrote:
On 01/03/2024 13:13, Christian Franke via Cygwin-apps wrote:
It IMO makes sense to compress large and rarely viewed doc files like change logs. This seems to be common practice on Debian etc.

With current cygport, the following results in ChangeLog and ChangeLog.gz in the docdir:

src_install()
{
   ...
   dodoc ChangeLog
   gzip -9 -n "${D}/usr/share/doc/${PN}/ChangeLog"
}

Uh, I don't quite see how this patch will change the behavior of this fragment.


Yes, it actually doesn't change the behavior of this fragment itself.


Even more confusing, why isn't this already doing what you want? Unless you specify -k/--keep to gzip, the input file is removed, right?

Yes - but after this src_install() the file will be re-added by __predoc() unless _CYGPORT_RESTRICT_postinst_doc_ is set. The patch avoids this because __predoc() also uses dodoc().

Ah, I get it.

Applied with a bit of rewording of the commit commentary for dullards like myself.

Thanks.

Reply via email to