On Thu, Jun 06, 2002 at 01:58:55AM +0100, Conrad Scott wrote:
>Oh! and I hope the Changelog's a little better this time. Good enough?
>
>Changelog message:
>* fhandler.cc (fhandler_base::fstat): Initialise tv_nsec member of st_atim,
>st_mtim, st_ctim fields.
>* fhandler_disk_file.cc (fhandler_disk_file::fstat_helper): ditto.
>* fhandler_process.cc (fhandler_process::fstat): ditto.
>* glob.c (stat32_to_STAT): Copy across the whole st_atim. st_mtime, st_ctim
>fields.
>* syscalls.cc (stat64_to_stat32): ditto.
>* times.cc (to_timestruc_t time_as_timestruc_t): New functions.
The ChangeLog is closer, but still not complete. You should provide a
*complete* ChangeLog, including time/date name, email address. The entries
should also be capitalized ("Ditto." not "ditto.").
If you can also indent the code, as per a normal ChangeLog, that is good,
too.
The goal is for this process to be as painless for the person applying the
patch as possible. There are two reasons for this 1) It's nice to be nice
and 2) A patch reviewer is apt to be more interested in a patch if it looks
clean and requires little or no editing. This means that your patch gets
applied faster and you get a reputation for submitting good patches (take
a bow Joshua).
There is no need to resubmit the ChangeLog with these trivial fixes but please
keep it in mind for your next submission.
Thanks, and now waiting for Corinna...
cgf
