Hi Thirumalai,
On 10/27/2025 1:23 AM, Thirumalai Nagalingam wrote:
Hi Everyone,
Please find the below attached patch for review.
* This patch fixes function declarations in shmtest.c by converting
definitions to
standard ANSI C prototypes to ensure compatibility with GCC 15.
Thanks & regards
Thirumalai Nagalingam
============
In-lined patch:
diff --git a/winsup/testsuite/winsup.api/shmtest.c
b/winsup/testsuite/winsup.api/shmtest.c
index e0b7acf7d..2c6c74e7a 100644
--- a/winsup/testsuite/winsup.api/shmtest.c
+++ b/winsup/testsuite/winsup.api/shmtest.c
@@ -74,10 +74,7 @@ key_t shmkey;
size_t pgsize;
-int
-main(argc, argv)
- int argc;
- char *argv[];
+int main(int argc, char **argv)
{
struct sigaction sa;
struct shmid_ds s_ds;
@@ -177,18 +174,14 @@ main(argc, argv)
exit (1);
}
Thanks for looking into this issue. Our Cygwin coding conventions
specify that function names should be at the left margin. So...
int
main(int argc, char **argv)
{
...
}
I've not patched the testsuite before so I'm unsure if the same
submission format applies here as applies to Cygwin DLL patches.
Namely, make the change in your git repo and commit it, use 'git
format-patch -1' to create a patch file, and then 'git send-email
<filename>' to mail it to [email protected]. Between the last
two steps, use an editor to add a patch description between the email
headers and your patch.
I am doubly unsure if all the tracking info added to DLL patches needs
to be added to testsuite patches. Here I mean Reported-by:, Addresses:,
Signed-off-by:, and Fixes:. Maybe someone else can chime in on this?
Thanks,
..mark
