On 2025-10-30 21:49, Mark Geisert wrote:
Hi Thirumalai,
On 10/27/2025 1:23 AM, Thirumalai Nagalingam wrote:
Hi Everyone,
Please find the below attached patch for review.
* This patch fixes function declarations in shmtest.c by converting
definitions to
standard ANSI C prototypes to ensure compatibility with GCC 15.
Thanks & regards
Thirumalai Nagalingam
============
In-lined patch:
diff --git a/winsup/testsuite/winsup.api/shmtest.c b/winsup/testsuite/
winsup.api/shmtest.c
index e0b7acf7d..2c6c74e7a 100644
--- a/winsup/testsuite/winsup.api/shmtest.c
+++ b/winsup/testsuite/winsup.api/shmtest.c
@@ -74,10 +74,7 @@ key_t shmkey;
size_t pgsize;
-int
-main(argc, argv)
- int argc;
- char *argv[];
+int main(int argc, char **argv)
{
struct sigaction sa;
struct shmid_ds s_ds;
@@ -177,18 +174,14 @@ main(argc, argv)
exit (1);
}
Thanks for looking into this issue. Our Cygwin coding conventions specify that
function names should be at the left margin. So...
int
main(int argc, char **argv)
{
...
}
Follow the GNU Coding Standards:
https://www.gnu.org/prep/standards/
distributed as part of the autoconf2.7 package:
$ info standards
although that is a few years out of date compared to the upstream
https://savannah.gnu.org/projects/gnustandards/
It may be useful to include "Information for Maintainers of GNU Software" with
cygport (and include the PDF in doc/ as well as info - ditto Standards)?
https://www.gnu.org/prep/maintain/
I've not patched the testsuite before so I'm unsure if the same submission
format applies here as applies to Cygwin DLL patches.
Namely, make the change in your git repo and commit it, use 'git format-patch
-1' to create a patch file, and then 'git send-email <filename>' to mail it to
[email protected]. Between the last two steps, use an editor to add a
patch description between the email headers and your patch.
I am doubly unsure if all the tracking info added to DLL patches needs to be
added to testsuite patches. Here I mean Reported-by:, Addresses:, Signed-off-
by:, and Fixes:. Maybe someone else can chime in on this?
We need to provide:
git format-patch -s|--signoff
git config format.signOff=true
to follow secure software development guidelines:
https://sourceware.org/cyber-security-faq.html
• Encourage signed git commits and store public keys in gitsigur.
• Record all review actions in the final commit using tags like Co-Authored-By,
Approved-By, Reviewed-By, Tested-By, Acked-by and add links to bugzilla and
review threads on inbox.sourceware.org
[or cygwin.com/pipermail/cygwin{,-apps,-developers,-patches}/
or sourceware.org/newlib/]
--
Take care. Thanks, Brian Inglis Calgary, Alberta, Canada
La perfection est atteinte Perfection is achieved
non pas lorsqu'il n'y a plus rien à ajouter not when there is no more to add
mais lorsqu'il n'y a plus rien à retrancher but when there is no more to cut
-- Antoine de Saint-Exupéry
