Yaakov (Cygwin Ports) wrote:
> Jon TURNEY wrote:
>> For me, Xming 6.9.0.31 doesn't draw title-bar less, shaped windows (like the
>> gmplayer control window) correctly at all.
> 
> True, that's one negative of Xming over XWin (even the old version).
> But it does get the WM hints right in all the cases I mentioned.
> 
>> I've looked through the patches on the Xming website, and whilst there is
>> some useful stuff there, I don't think there is a fix for this particular
>> issue (there's also a secondary problem that I'm not quite sure if they
>> actually match up with that release.  They certainly don't have some of the
>> stuff from later releases.)
> 
> Hopefully in the next few weeks I'll have the time to look these over in
> more detail.

The xming patches aren't in an ideal format to work with, as they are split up
by file and tend to have changes mixed together (I guess they are in
chronological rather than thematic order or something)

Anyhow, here's my current patch stack using xming derived stuff:

http://www.dronecode.org.uk/cygwin/from-xming-patch-set-20081024.tar.bz2

Note the series file. :-)

With from-xming-patch11-wm-fixes.patch + my cygwin-notitle-shape-fix.patch
no-title-bar shaped windows have no title bar and the correct clipping region.
There's still something wrong about the way the contents are drawn though,
which looks to be related to the way the dimensions of the window change when
the frame and titlebar are removed, that I can't quite figure out...

I will be looking at the xming patches some more. I hope we can co-ordinate
to avoid duplicating effort.

I've exchanged email with the Xming maintainer and he says it's ok to treat
these patches as MIT/X11 licensed, even though they are CC licensed on the
website.

>> Yes and no.  There have been changes, but only as part of changes made across
>> the Xserver code base.  There are very few if any Xwin fixes that have been
>> merged in.
> 
> My impression is that upstream considers hw/xwin without a maintainer,
> and the Xming maintainer has (wisely) refrained from pushing his patches
> unilaterally.  I hope that, thanks to your help, we can work together to
> change that situation.
> 
>> Not quite sure you mean here.  Do you refer to the problem where the icons
>> have a little black & white "noise" around the edges?(As seen with gtk-demo)
>> I did look into this briefly and the problem seems to be that the icons have
>> to be resized for  windows, and the code does this in simple-minded way.
> 
> No, what I meant was the problem only with Qt4 application icons where
> the shape of the icon is correct but is filled with B&W static.  Compare
> the results of, for instance, designer-qt4 in multiwindow mode versus
> the behaviour of openbox, xfwm4, metacity, or kwin.

Ah, right. Very interesting.

The Qt4 designer "New Form" window gets a monochrome bitmap because that's
the one pointed to the _WM_HINTS property. There's a nice colour icon in
_NET_WM_ICON, but we don't support that.

Fortunately there's some more code in the patch in fd.o bugzilla #4491 to
handle these. Unfortunately it's not quite finished in a couple of ways:
need to rescale the icon to the size needed by windows (and some kind of
policy to choose the 'best' icon to rescale), and needs some thought about
what it needs to do to work correctly on versions of Windows which don't
have support for alpha-blended icons (truncate the alpha channel to a
monochrome mask bitmap somehow?)

I get the standard X logo icon for the rest of Qt4 designer's windows. I
can't quite work out where other WMs are getting the 'drawing compass'-like
icon from....


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cygwin-ports-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cygwin-ports-general

Reply via email to