Yaakov (Cygwin Ports) wrote:
> Jon TURNEY wrote:
>> Attached tarball contains a revised patch-set + series file for X server
>> 1.5.2
>
> Thank you once again! I just checked this into SVN, could you please
> svn up and test again?
Works ok for me :-)
I've updated the cygwin setup package at http://www.dronecode.org.uk/cygwin/
if anyone else would like to try it.
There seems to be a stray bit of debug output in ApplyHints, attached svn diff
should tidy that up.
> FYI, I've made a few minor changes to your cygwin-build-fixes.patch:
> * XWin.o does not need to be added to XWin_LDADD; it is already part of
> XWin_SOURCES.
Well spotted. Thanks
> * I removed -static from XWin_LDFLAGS (static libXfont is handled in the
> .cygport; everything else can be shared).
> * Added a fix for 'make relink'.
>
> I'm omitting from-xming-patch2-resources-update.patch because I have my
> own reworking of the About window.
Looks much nicer. It might be a good idea to say this is the X.Org server,
although you may well think "Cygwin/X X.Org X server" has too many X's :-)
> I did notice one regression: in xine, right clicking on the display
> window brings up a menu. The menu previously remained open until a
> selection was made (or if you click outside the menu); with the newest
> patches, the menu appears and disappears immediately. (FYI, this menu,
> unlike most, is considered by the WM as a window.)
Hmm.. I can't reproduce this right now, using non-local xine client.
The drawing of the menu is not very smooth sometimes, though.
>> Next I'll look at the icon problems we've discussed previously, and there are
>> some clipboard improvements in Xming I want to understand, unless you have
>> other suggestions.
>
> Could you look over my latest comments on the deprecated extensions and
> let me know what you think?
>
> While there's certainly room for further development of XWin, I think
> that we just about have a solid X11 that can be pushed into the distro.
> I hope that doing so will get a lot more eyeballs looking at XWin, and
> bring more developers on board.
>
> Here's what I'm thinking for a plan, which I would like to finish steps
> 1-7 within the next 2-3 weeks:
>
> 1) Fix the aforementioned regression in xine ASAP.
> 2) I'll upload xorg-server-1.5.2, mesa-7.2-2 and other updates to Ports.
> 3) Finalize decision on modules/extensions to exclude.
> 4) I'll propose to take over as Cygwin/X coordinator within the distro;
> I hope you will be able to stick around as a developer.
> 5) Move the X.Org packages from Ports to the distro, and fix up other
> packages' dependencies accordingly (already computed).
> 6) Announce the upgrade to [EMAIL PROTECTED]
> 7) Further X11 discussion moves to [EMAIL PROTECTED]
> 8) Deal with fallout from transition, continue development, and start
> pushing patches upstream.
> Thoughts?
It's a plan!
Index: cygwin-hint-handling-fixes.patch
===================================================================
--- cygwin-hint-handling-fixes.patch (revision 4860)
+++ cygwin-hint-handling-fixes.patch (working copy)
@@ -13,9 +13,9 @@
---
xserver/hw/xwin/winmultiwindowshape.c | 14 ++++++++++
- xserver/hw/xwin/winmultiwindowwm.c | 7 ++++-
+ xserver/hw/xwin/winmultiwindowwm.c | 5 +++
xserver/hw/xwin/winmultiwindowwndproc.c | 42
++++++++++++++++++++++++--------
- 3 files changed, 52 insertions(+), 11 deletions(-)
+ 3 files changed, 50 insertions(+), 11 deletions(-)
Index: xorg-server-1.5.2/xserver/hw/xwin/winmultiwindowshape.c
===================================================================
@@ -50,16 +50,7 @@
===================================================================
--- xorg-server-1.5.2.orig/xserver/hw/xwin/winmultiwindowwm.c
+++ xorg-server-1.5.2/xserver/hw/xwin/winmultiwindowwm.c
-@@ -1466,6 +1466,8 @@ ApplyHints (Display *pDisplay, Window iW
- if (!hWnd) return;
- if (!IsWindow (hWnd)) return;
-
-+ ErrorF("ApplyHints: hWnd 0x%x\n", hWnd);
-+
- if (windowType == None) windowType = XInternAtom(pDisplay,
"_NET_WM_WINDOW_TYPE", False);
- if (windowState == None) windowState = XInternAtom(pDisplay,
"_NET_WM_STATE", False);
- if (motif_wm_hints == None) motif_wm_hints = XInternAtom(pDisplay,
"_MOTIF_WM_HINTS", False);
-@@ -1486,12 +1488,13 @@ ApplyHints (Display *pDisplay, Window iW
+@@ -1486,12 +1486,13 @@ ApplyHints (Display *pDisplay, Window iW
{
SetWindowLongPtr (hWnd, GWL_STYLE, (GetWindowLongPtr(hWnd, GWL_STYLE) &
~WS_OVERLAPPEDWINDOW) | WS_SIZEBOX);
SetWindowPos (hWnd, HWND_TOPMOST, 0, 0, 0, 0, SWP_NOSIZE | SWP_NOMOVE |
SWP_FRAMECHANGED | SWP_NOACTIVATE);
@@ -74,7 +65,7 @@
}
}
}
-@@ -1534,6 +1537,8 @@ ApplyHints (Display *pDisplay, Window iW
+@@ -1534,6 +1535,8 @@ ApplyHints (Display *pDisplay, Window iW
{
SetWindowLongPtr (hWnd, GWL_STYLE, GetWindowLongPtr(hWnd, GWL_STYLE) &
~WS_OVERLAPPEDWINDOW);
SetWindowPos (hWnd, NULL, 0, 0, 0, 0, SWP_NOSIZE | SWP_NOMOVE |
SWP_FRAMECHANGED | SWP_NOACTIVATE | SWP_NOZORDER);
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Cygwin-ports-general mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/cygwin-ports-general
