On Sat, 1 Sep 2007, Bron Gondwana wrote:
On a more structural note - it would be great to re-factor the lower level APIs (mailbox.c, mboxlist.c, etc) to provide everything that sync_server needs manipulate their data structures and remove all the low level fiddling copy-and-pasted stuff from the sync layer. This comes back a bit to David's comments today about the difficulty of having patches flying around - I suspect he copied and pasted so he wasn't throwing tentacles deep through the main codebase - but the end result is more brittle software and poor abstraction.
Pretty much. I wasn't expecting the replication code to ever get merged when I first wrote it. All of the really awful stuff should be in sync_commit.c. Those are the routines which create messages with predetermined UIDs and mailboxes with predetermined UniqueIDs.
-- David Carter Email: [EMAIL PROTECTED] University Computing Service, Phone: (01223) 334502 New Museums Site, Pembroke Street, Fax: (01223) 334679 Cambridge UK. CB2 3QH.
