On Mon, Jul 14, 2008 at 9:07 PM, Paul McNett <[EMAIL PROTECTED]> wrote: > Nate Lowrie wrote: >> On Mon, Jul 14, 2008 at 1:09 PM, Paul McNett <[EMAIL PROTECTED]> wrote: >>> I want to do it, but up until now I felt I was the only one. I thought I >>> was going to need this for something I was working on but implemented it >>> differently, so its no longer critical for me. >> >> If I implement Ticket 1034 would y'all be willing to include it? If >> so, do you want to do the first or second way as described in the >> ticket? > > Well I think it would depend on a number of things, including how well > it is implemented. :) > > I like way #1, but I don't like how much it will rock the boat with > existing applications, and I can't picture how we could do > DeprecationWarnings if we are to retain the dForm and dDialog names. > > Way #2 is probably better in a practical sense (dForm and dDataDialog > would mix-in dBaseForm/Dialog and the data mediator; dBaseForm and > dDialog wouldn't, leaving them as the are right now. But it does add > some smell long-term. > > First step would to make the data mediator mixin. > > Also, I don't believe Ed has ever weighed in on this ticket (I could be > wrong, though). > > Do it in a branch so we can try it out first.
Well, the way things are currently setup is that all the bizobj awareness code is in a class called BaseForm in dForm.py. That said, your fix to Ticket 1035 actually creates a bizobj aware dialog essentially because the dialog subclasses BaseForm instead of dFormMixin. It would be possible, for the time being to create the dDataDialog simply by subclassing BaseForm instead of dFormMixin. The other way to handle this is to make no distinction whatsoever and have every dialog and form be data aware... I'll see what I can come up with but let the discussion continue. Nate L. _______________________________________________ Post Messages to: [email protected] Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev Searchable Archives: http://leafe.com/archives/search/dabo-dev This message: http://leafe.com/archives/byMID/[EMAIL PROTECTED]
