On Aug 2, 2008, at 3:05 PM, Nate Lowrie wrote:
> Added menu item type support to the mnxml processing. Attribute in
> mnxml is MenuType. Defaults to "" when attribute is not present, so
> the change is backwards compatible.
Thanks for doing this, but how did you manage to commit and wipe out
the change I posted this morning? Either you should have merged my
changes first, or svn should not have allowed you to do this.
> + type = menu._extractKey(itmatts, "MenuType", "")
Reserved words, such as 'type', should never be used as names.
Typically I use 'typ' or, for this case, 'mtype' or 'menuType'.
I'll fix both of these and re-commit. But I'm very interested in
learning why svn didn't catch that your version was old before
allowing you to commit.
-- Ed Leafe
_______________________________________________
Post Messages to: [email protected]
Subscription Maintenance: http://leafe.com/mailman/listinfo/dabo-dev
Searchable Archives: http://leafe.com/archives/search/dabo-dev
This message: http://leafe.com/archives/byMID/[EMAIL PROTECTED]
