On Fri, Dec 19, 2008 at 11:24 AM, Steve Hay <steve...@planit.com> wrote: > Rafael Garcia-Suarez wrote: >> 2008/12/19 karl williamson <pub...@khwilliamson.com>: >>> Two things: when I do as above using rsync, I merely get a list of >>> the valid perl sources. If I change the :: to a slash, I actually >>> get the files. However, .patch contains >>> "blead 20081219.17:05:08 b1fccde5a5d6d9eece3886ce5cb9dc7b9027bee2" >>> which doesn't compile well. >> >> What is exactly the problem with that ? I don't think anything relies >> on .patch being an integer, but I might be wrong. > > Nothing wrong with it here. I did a little smoke test using the new > rsync source earlier, and it built fine (see attached).
I think that's because Test::Smoke did it's own editing of patchlevel.h. It didn't blow up, but it also didn't really work. You'll notice all of the hex digits have been stripped from your SHA1. Since the timestamp is embedded in there it's reasonably safe but not entirely correct.
