* Pavel Shramov <[EMAIL PROTECTED]> [081118 11:10]: > On Mon, Nov 17, 2008 at 09:45:38PM +0100, Christian Kellermann wrote: > > Hm, this fits perfectly the IRC discussion I followed. Adds another > > option to the import statements and changes make_email to insert a > > Reply-To: and References: header supposedly to aid MUAs sorting > > this into the right thread. > I've not mentioned that this patch closes issue 1144 [1]. After > using git for a year I miss this functionality from darcs... :) > > > Technically this looks ok to me but it adds yet another flag. > Thanks > > > Thanks also for providing a testsuite! > Tests are recommended in wiki [2] so why not to follow these 'rules'. > > > Did the testsuite pass the tests on this patch? > Yes. make check passes. Unfortunately I was not patient enough to wait > for make disttest since it tries to fetch full copy of franchise on each > run :(
make check seems enough to me for this one. If you like you can amend the patch and prepend the patchname with 'resolve issue1144:' Then the bugtracker will automagically close the bug. I am looking forwared seeing more like this :) Thanks again! Christian -- You may use my gpg key for replies: pub 1024D/47F79788 2005/02/02 Christian Kellermann (C-Keen)
pgpi0BCwyad0v.pgp
Description: PGP signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
