On Fri, Aug 7, 2009 at 4:21 AM, Petr Rockai<[email protected]> wrote:
We should use the -fwarn-tabs patch you submitted. As for based on your patches -- I started that way, but then I realized that would create a number of versions that cannot pass the tests, without enough justification -- if the change is a single patch, both before and after the tests pass just fine, not disrupting trackdown. I would have done most of the changes I did anyway -- I just squashed them, together with your original patches, into a single patch.Yours, Petr.
Then there must be something I am missing about the test infrastructure. I don't see how the tests could fail if the patches followed my sequence of 1. adding -fwarn-tabs to darcs.cabal 2. adding a hints file 3. tightening the hlint hints per your version 4. adding a hlint script 5. adding the ratify module 6. changing all the necessary imports to use the ratify module & 7. deleting the haskell_policy.sh and replacing it with the hlint script Small, logical, self-contained patches which don't break the test setup at any point and which don't have deps on a bunch of files. Seems better than one big patch. -- gwern
signature.asc
Description: OpenPGP digital signature
_______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
