Ganesh Sittampalam <[email protected]> added the comment: > Fri Jan 29 10:58:22 CET 2010 Florent Becker <florent.bec...@ens- lyon.org> > * Give Darcs.SelectChanges.text_view a sane type
Definitely looks good > Fri Jan 29 17:20:00 CET 2010 Florent Becker <florent.bec...@ens- lyon.org> > * add seals in Changes to prepare for witnesses This one looks good too. The basic point is that we are now giving up on witnesses for viewing changes, which makes reasonable sense given that (a) it's a low-risk activity and (b) filtering changes makes witnesses a nightmare. Along the way, the patch gets rid of the use of TaggedPatch in text_view in Darcs.SelectChanges, which seems appropriate as the tags don't seem to have been used anywhere. > Sun Jan 31 17:25:39 CET 2010 Florent Becker <florent.bec...@ens- lyon.org> > * Remove useless case in Patch.Bundle Looks ok, do we know how the code got into this state? > Sun Jan 31 22:55:19 CET 2010 Florent Becker <florent.bec...@ens- lyon.org> > * Allow PatchSets not to start at the origin of the repo As per my previous email, I'm still not convinced by this. It changes a lot of code for one particular use case (which I guess is in the patch adding witnesses to Changes, which I haven't read carefully yet). Is it really worth it? > Wed Jan 27 14:19:24 CET 2010 Florent Becker <florent.bec...@ens- lyon.org> > * Rename filterFL to filterFLFL, replace it with a version using Sealed2 This cleans up a confusion introduced by the addition of filterRL earlier: the type/usage of the newly added filterRL wasn't at all consistent with the existing filterFL. > Mon Feb 1 01:15:47 CET 2010 Florent Becker <florent.bec...@ens- lyon.org> > * Add witnesses to Darcs.Commands.Changes I haven't read this carefully yet, but I didn't spot any obvious problems on a quick glance. __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch149> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
