Ganesh Sittampalam <[email protected]> added the comment: > Mon Feb 1 01:15:47 CET 2010 Florent Becker <[email protected]> > * Add witnesses to Darcs.Commands.Changes
This one looks fine too. One minor comment is that you've left in my comment in witnesses.hs which is intended to explain why modules aren't yet witnessed and is therefore no longer relevant. Also, your patch series seems to have conflicts. If it's difficult for you to amend, it's not a big deal, but otherwise it might be nice to do so. So I think the only significant issue is that I'd like to discuss the extra type argument to PatchSet further before accepting these patches. __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch149> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
