On Sun, 14 Nov 2010, Iago Abal wrote:

Ok, I get your point, though in this case I think a simple (and inoffensive)
where clause will improve readability. A short comment will do the job too.

Oh I see, you want to leave the behaviour obviously unaltered, just refactor. That's fine, and I [also?] think sharing the two tests you refer to in one place would definitely make sense.

I know when I do some of these commentaries I could be considered too
"picky", so let me know if you [don't] want to receive this sort of comments
about Darcs code.

I think it's definitely worth discussing everything: even if we don't make changes to the code today, it's worth remembering for later.

Ganesh
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to