Am Montag, 3. Oktober 2016, 20:56:39 CEST schrieb Jan Ingwer Baer: > Hi,
Hi. [...] > - In common/film.c function film_recursive_get_files() there is a > mistake in the call to function g_build_filename(). It is called with > the same parameters as g_build_pathname(), but according to the glib > manual it does not need the first parameter (G_DIR_SEPARATOR_S). Under > windows this will produce an invalid filename with a leading slash (like > /c:/user/...). Under *ix this no problem because it will simple double > the leading slash of an absolute path what the os ignores. Fixed in master. > - In common/darktable.c function strip_semicolons_from_keymap() there is > only a test for the result of fgetc() !=eof. But on mingw this doesnt > work, and it must test for feof() ==0. Without the test for feof() the > result is an infinite loop... Then your implementation of fgetc is broken. It is required to return EOF when the end of the file is reached. Maybe it's a problem with line endings? [...] > Greetings from Berlin > > Jan Ingwer Baer Thanks for reporting the bug. Tobias
signature.asc
Description: This is a digitally signed message part.
