Hi everyone, The colorbalance is done and I have added HSL sliders to make it really quick to set (altough now, the UI is quite crowded). It's the closest I can go to the color wheels, given that I don't know much about cairo.
The new mode works in ProPhoto RGB, I still have a problem with the colorspace conversion in the SSE2 version : converting back and forth produces a slight magenta cast. I'm bumping my head to understand why, since the pure C and OpenCL versions work flawlessly with the same algorithm. If you want to test or review : https://github.com/darktable-org/darktable/pull/1734 If someone wants to finish the color wheels, you just have to map the radius to what is passed to the current saturation slider, and the angle to what is passed to the current hue slider. The maths are ready and working. Have a nice day, Aurélien. Le 21/09/2018 à 20:32, Aurélien Pierre a écrit : > > Hi, > > I'm to add the ASC CDL mode (https://en.wikipedia.org/wiki/ASC_CDL) in > RecRGB 2020 into the colorbalance module. > > I have seen the prototype of the code for color wheels, from Tobias, > and the comment : > > // these are not in a state to be useful. but they look nice. too > bad i couldn't map the enhanced mode with > // negative values to the wheels :( > > What exactly didn't work ? If the problem is merely mathematical, I > can work on it. I'm just bad at GUIs and GTK stuff. > > On another note, is it mandatory to make the adjustement in sRGB ? > (why not a larger RGB space ?) > > Cheers, > > Aurélien. > > > ___________________________________________________________________________ > darktable developer mailing list to unsubscribe send a mail to > darktable-dev+unsubscr...@lists.darktable.org ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
