I think we still have default-on modules not recorded in history stack (highlight reconstruction and white balance), so removing all “off” steps might modify the image. Therefore I’m afraid your implementation is incorrect. Best approach would be to record all applied iops to history, but it’s a little tricky due to backwards compatibility (though I think we did similar change before) - then your commit will work. Another approach is to add exceptions for specific iops, but that’s ugly IMHO.
> On 10 Jun 2019, at 15:05, dt-l...@stefan-klinger.de wrote: > > Hi, > > I've drafted [1] an implementation to make "compress history stack" to > also remove all unused modules, i.e., the ones switched off. But > there are some questions: > > 1. This was so easy to do, maybe it's a bad idea to do this at all? > > 2. I have derived the SQL from looking at other statements in the > source. I have no deep knowledge about DT's architecture, so > someone needs to verify that the query does not mess with other > stuff. > > 3. I think deleting unused modules should be optional. How should I > implement that? > > * There could be a checkbox "remove unused moduls" next to the > "compress history stack" button. I think this is the most > simple option. > > * Maybe "remove unused moduls" and "compress history stack" > should be entirely separate operations? I'm not sure about > the exact semantics though: What, precisely, should the > former do without the latter? Maybe delete all mentions of a > module below and up to the one where it's switched off? > > * Maybe the (currently unused) "presets" menu of darktable's > "history" module should be used to host these operations? > > Cheers, > Stefan > > ____________________ > [1] > https://github.com/darktable-org/darktable/compare/master...s5k6:compressHistory > > > > -- > http://stefan-klinger.de o/X > I prefer receiving plain text messages, not exceeding 32kB. /\/ > \ > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
