Hi, I'm the author of the lighttable's compress history button. White balance and highlight reconstruction should never be turned off, so what would be the purpose of having them disabled in the first place ? Then, we can discuss what the history compression should do/avoid/prevent.
Aurélien. Le 12/06/2019 à 11:40, dt-l...@stefan-klinger.de a écrit : > thokster (2019-Jun-11, excerpt): >> Hi, >> >> Am 11.06.19 um 15:32 schrieb dt-l...@stefan-klinger.de: >> >>> This option is not about saving disk space, but rather about cleaning >>> up. >> Is the "compress history" button in lighttable view doing anything else? > Woha. I have been talking about "compress history" in darkroom, not > lighttable. > > They seem not to use the same code internally. > > I have to admit that I have not thought about the "compress history" > button in lighttable. That one already seems to remove switched-off > modules in current master [1]. And it seems to do this incorrectly > wrt. parafin's email: > > * In darkroom, disable "white balance" and/or "highlight > reconstruction". > > * Go to lighttable, select that image, and apply "history stack → > compress history" > > * When you open the image again, "white balance" and "highlight > reconstruction" will be enabled again. > > So if compressing should not change the image, then my current > implementation [2] is even more correct, although it only is > applicable from darkroom, not lighttable. > > Cheers > Stefan > > ____________________ > [1] 2.7.0+1443~g9bfbb225e > [2] > https://github.com/darktable-org/darktable/compare/master...s5k6:compressHistory > > > -- > http://stefan-klinger.de o/X > I prefer receiving plain text messages, not exceeding 32kB. /\/ > \ > ___________________________________________________________________________ > darktable developer mailing list > to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org > ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
