On 23/01/13 05:47 PM, Pascal Obry wrote:
[snip]
>> at least i wouldn't feel comfortable to include it in a 1.2 release so
>> far (which was originally planned to release from master quite soon).
>
> Too bad indeed! If we want this out of 1.2 then we just have to "#if 0"
> the section creating the button.
Please, don't do that. Using "#if 0" indicates laziness -
if the code should not be compiled, then it should not be
in the file.
Code guarded by "#if DEBUG" is different, because given -DDEBUG=1
passed in CFLAGS, the block is compiled in. There is no way that
0 can be True, so that block would never be compiled in.
Code which is never compiled quickly rots.
James C. McPherson
--
Solaris kernel software engineer, system admin and troubleshooter
http://www.jmcpdotcom.com/blog
Find me on LinkedIn @ http://www.linkedin.com/in/jamescmcpherson
------------------------------------------------------------------------------
Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS,
MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current
with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft
MVPs and experts. ON SALE this month only -- learn more at:
http://p.sf.net/sfu/learnnow-d2d
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
