From: David Brownell
Sent: Monday, March 16, 2009 1:50 PM
> On Sunday 15 March 2009, nar...@ti.com wrote:
> > @@ -167,6 +175,8 @@ enum fifo_width {
> > enum dma_event_q {
> > EVENTQ_0 = 0,
> > EVENTQ_1 = 1,
> > + EVENTQ_2 = 2,
> > + EVENTQ_3 = 3,
> > EVENTQ_DEFAULT = -1
> > };
> >
>
> It'd be good to get rid of that enum entirely ... just use the
> TC number, except maybe for
>
> EVENTQ_HI_PRIORITY ... maybe higher priority than ARM
> EVENTQ_LO_PRIORITY ... low priority, e.g. for bulk
> EVENTQ_DEFAULT ...
>
> Expecting drivers to deal with TC queues in anything other than
> generic terms is a losing game; except maybe for SoC-specific
> code, which should be rare.
Factors like FIFOSIZE may also play role in using a particular TC for a
particular peripheral (eg. on DM648, TC 2 & 3 are optimized for video because
of high FIFOSIZE). Not having fine grained control can be a problem in such
cases.
But agreed that drivers should not be making the choice as the choice is not
generic. I think TC to be used should be coming from platform data?
Thanks,
Sekhar
>
> - Dave
>
>
>
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@linux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
