> -----Original Message----- > From: naresh [mailto:x0090...@ti.com] > Sent: Wednesday, March 18, 2009 4:59 PM > To: 'nar...@ti.com'<mailto:'nar...@ti.com'> > Subject: > > On Sunday 15 March 2009, nar...@ti.com<mailto:nar...@ti.com> wrote: > > @@ -167,6 +175,8 @@ enum fifo_width { > > enum dma_event_q { > > EVENTQ_0 = 0, > > EVENTQ_1 = 1, > > + EVENTQ_2 = 2, > > + EVENTQ_3 = 3, > > EVENTQ_DEFAULT = -1 > > }; > > > > It'd be good to get rid of that enum entirely ... just use the > TC number, except maybe for > > EVENTQ_HI_PRIORITY ... maybe higher priority than ARM > EVENTQ_LO_PRIORITY ... low priority, e.g. for bulk > EVENTQ_DEFAULT ... > > Expecting drivers to deal with TC queues in anything other than > generic terms is a losing game; except maybe for SoC-specific > code, which should be rare. >
Yes it would be meaningfull if the event queues are named according to the prioirity > - Dave > Regards Naresh
_______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
