Russell King - ARM Linux <[email protected]> writes:

> On Wed, Apr 15, 2009 at 10:38:13AM -0500, Kevin Hilman wrote:
>> +            sprintf(name, "uart%d", i);
>> +            uart_clk = clk_get(dev, name);
>> +            p->uartclk = clk_get_rate(uart_clk);
>> +            if (IS_ERR(uart_clk))
>
> Umm, isn't this wrong?

Yes, it's wrong.  It happens to work because dev_id == NULL in this
clkdev, but it would be clearer if I change the dev to NULL in the
clk_get().

Kevin

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to