Russell King - ARM Linux <li...@arm.linux.org.uk> writes:
> On Fri, May 15, 2009 at 05:58:31PM -0700, Kevin Hilman wrote:
>> +void davinci_get_mac_addr(struct memory_accessor *mem_acc, void *context)
>> +{
>> + DECLARE_MAC_BUF(mac_str);
>> + struct davinci_soc_info *soc_info = davinci_get_soc_info();
>> + char *mac_addr = soc_info->emac_pdata->mac_addr;
>> + off_t offset = (off_t)context;
>> +
>> + /* Read MAC addr from EEPROM */
>> + if (mem_acc->read(mem_acc, mac_addr, offset, 6) == 6) {
>
> These probably want to be ETH_ALEN ?
The updated/pushed version of this patch (in the for-next branch, also
appended below) already had these replaced with ETH_ALEN. I replaced
them all after you caught these in previous patches.
>> diff --git a/arch/arm/mach-davinci/include/mach/emac.h
>> b/arch/arm/mach-davinci/include/mach/emac.h
>> index 84d3372..27f7949 100644
>> --- a/arch/arm/mach-davinci/include/mach/emac.h
>> +++ b/arch/arm/mach-davinci/include/mach/emac.h
>> @@ -11,6 +11,8 @@
>> #ifndef _MACH_DAVINCI_EMAC_H
>> #define _MACH_DAVINCI_EMAC_H
>>
>> +#include <linux/memory.h>
>
> Hmm, not sure that's right actually - please check.
Yes, this is correct. It's for the definition 'struct
memory_accessor' arg.
Kevin
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
