On Fri, Jun 04, 2010 at 16:46:28, jean-philippe francois wrote: > > Unless you insist, I would prefer to leave the define at its current place. > > First of all, many people (including me) expect to find defines somewhere > > near the beginning of a source file. More importantly, if a definition is > > valid throughout the entire file, it is easier to later add code that also > > depends on that definition, without having to move it again. > > > > As far as I am concerned, when a define is used in a single place, I > find it easier > to have it near the place where it is used. And I don't think we will > need to add further reference > to this define, since the precise purpose of this platform data is to > stop caring about the hardware > base address.
Agree with jean-philippe here, that's the general rule we have been following in DaVinci tree. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
