On 11/23/2010 12:20 AM, Mark Brown wrote: > On Sun, Nov 21, 2010 at 02:31:38PM -0700, Grant Likely wrote: >> On Sun, Nov 21, 2010 at 1:02 PM, Ryan Mallon <r...@bluewatersys.com> wrote: > >>> Currently the code will allow you to install >>> several peripherals at once, which will lead to odd behaviour at >>> runtime. Maybe a better approach would be to have something like this in >>> drivers/mfd/ti-ssp.c: > >> Only the ssp core itself is allowed to register the peripheral >> devices, and so using the parent pointer is perfectly valid. I think >> Cyril's approach is fine. > > This is very much a standard idiom for MFD children in Linux - if the > children are entirely reliant on working through a parent-specific API > anyway there's no issue with making the parent device be part of that > API.
Yeah, I misunderstood how the registration worked. It is fine as is, ignore my comments :-). ~Ryan -- Bluewater Systems Ltd - ARM Technology Solution Centre Ryan Mallon 5 Amuri Park, 404 Barbadoes St r...@bluewatersys.com PO Box 13 889, Christchurch 8013 http://www.bluewatersys.com New Zealand Phone: +64 3 3779127 Freecall: Australia 1800 148 751 Fax: +64 3 3779135 USA 1800 261 2934 _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
