Hi Sergei and Sugosh, I'm sorry to jump in so late, but I think (hope) I may have a compromise-solution.
On Thu, Feb 3, 2011 at 7:25 AM, Sergei Shtylyov <sshtyl...@mvista.com> wrote: > On 03-02-2011 15:16, sughosh ganu wrote: > >> > diff --git a/arch/arm/mach-davinci/Kconfig >> > b/arch/arm/mach-davinci/Kconfig >> > index 32f1479..e13b7e0 100644 >> > --- a/arch/arm/mach-davinci/Kconfig >> > +++ b/arch/arm/mach-davinci/Kconfig >> > @@ -213,6 +213,16 @@ config MACH_MITYOMAPL138 >> > config MACH_OMAPL138_HAWKBOARD >> > bool "TI AM1808 / OMAPL-138 Hawkboard >> > platform" >> > depends on ARCH_DAVINCI_DA850 >> > + select MTD >> > + select MTD_PARTITIONS >> > + select MTD_CHAR >> > + select MTD_BLKDEVS >> > + select MTD_BLOCK >> > + select MTD_PHYSMAP >> > + select MTD_CFI >> > >> > >> > >> > I don't think CFI is necessary for NAND? >> > >> > >> > >> > Neither is the 'physmap' driver. And all this part of >> the >> > patch looks completely bogus. >> > >> > >> > >> > I think MTD_CFI and MTD_PHYSMAP are not needed. I need the rest >> of the >> > options for mtd related stuff. I guess i can include these in >> the same >> > patch. Will come up with an updated revision. Thanks. > >> Why do you need to select these through Kconfig. Why cant >> these >> be enabled/disabled by users using menuconfig? > >> Since the hawkboard comes with a default Nand chip, i thought >> these could >> be part of the default config. But i see that these configs are >> not >> defined for for other ARM boards(except PXA). In that case, i >> can >> remove >> these configs from the deault. Thanks. > >> Looking through the defconfigs, looks like a lot of boards define >> the >> configs >> for MTD as default. > >> So what? Defconfigs are not created by forcing the options via >> Kconfig, >> they are created by manually configuring in the needed options. > >> Hmm. So then how do you suggest me to get the MTD configurations for the >> board. I think it makes sense to get these as NAND comes mounted by >> default(as >> i pointed in my earlier mail). The da8xx_omapl_defconfig is shared by >> multiple >> boards, and this is the way i see things being configured for individual >> boards, e.g MACH_DAVINCI_DA830_EVM. > > I don't understand, what's the way? DA830 EVM doesn't force unnecessary > options. > >> If there is any better way, let me know. > > If you really want to enable the NAND related options, just change > da8xx_omapl_defconfig. Sergei, perhaps it would be acceptable for the Hawkboard MACH_OMAPL138_HAWKBOARD bool to be the 'default' for the necessary MTD settings? This would be similar to KEYBOARD_GPIO_POLLED in 9cc3049911d0166d54247cf2471802eb5293c66c and GPIO_PCA953X in d5539ca0a5c9abd5cbf9ddcbbc1c2a507b5fd63c. Sugosh, this means you would make an entry in arch/arm/mach-davinci/KConfig for each of the 'selects' above. Something like: config MTD default MACH_OMAPL138_HAWKBOARD config MTD_PARTITIONS default MACH_OMAPL138_HAWKBOARD [etc.] I agree that MTD_CFI and MTD_PHYSMAP are not needed and so should not be included in the 'defaults.' Again, I am sorry for jumping in at the last minute -- I would like to see the da850's get the best mainline support possible and I hoped that this suggestion could help accomplish that. Best Regards, Ben Gardiner --- Nanometrics Inc. http://www.nanometrics.ca _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
