Hello,
Can we not have the PRU UIO also as a part of the MFD framework.
I know that the UIO is not really a device, but I feel its incorrect to
register the same device twice.
Instead we can have a single entry as the MFD framework and the UIO, as a
child device, based upon the MFD driver APIs.
All that we need to do is add an entry into the da8xx_pruss_devices
structure
and the MFD driver will do the rest to get the UIO probe called.
--------------------------------------------------
From: "TK, Pratheesh Gangadhar" <prathe...@ti.com>
Sent: Monday, February 28, 2011 6:34 PM
To: "Subhasish Ghosh" <subhas...@mistralsolutions.com>;
<davinci-linux-open-source@linux.davincidsp.com>
Cc: <sa...@mistralsolutions.com>; "Russell King" <li...@arm.linux.org.uk>;
"Kevin Hilman" <khil...@deeprootsystems.com>; "open list"
<linux-ker...@vger.kernel.org>; "Watkins, Melissa" <m-watk...@ti.com>;
<linux-arm-ker...@lists.infradead.org>
Subject: RE: [PATCH v2 02/13] da850: pruss platform specific additions.
Hi,
-----Original Message-----
From: davinci-linux-open-source-boun...@linux.davincidsp.com
[mailto:davinci-linux-open-source-boun...@linux.davincidsp.com] On Behalf
Of Subhasish Ghosh
Sent: Friday, February 11, 2011 8:21 PM
To: davinci-linux-open-source@linux.davincidsp.com
Cc: sa...@mistralsolutions.com; Russell King; Kevin Hilman; Subhasish
Ghosh; open list; Watkins, Melissa; linux-arm-ker...@lists.infradead.org
Subject: [PATCH v2 02/13] da850: pruss platform specific additions.
This patch adds the platform device and assignes the platform resources
for the PRUSS mfd driver.
Signed-off-by: Subhasish Ghosh <subhas...@mistralsolutions.com>
---
+struct platform_device da8xx_pruss_dev = {
Can you please rename this to da8xx_pruss_mfddev?
+ .name = "da8xx_pruss",
Can you please rename name string as pruss_mfd? This will help to
base my UIO patches on top of yours.
+ .id = -1,
+ .num_resources = ARRAY_SIZE(da8xx_pruss_resources),
+ .resource = da8xx_pruss_resources,
+};
+
+int __init da8xx_register_pruss(struct da8xx_pruss_devices
*pruss_device)
Please rename this to da8xx_register_pruss_mfd
Thanks,
Pratheesh
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
