On Wed, Dec 28, 2005 at 11:11:31PM +0000, Tim Bunce wrote:
>   http://www.data-plan.com/public/DBD-Oracle-1.17.tar.gz
> 
> =head1 Changes in DBD-Oracle 1.17 (svn rev 2334)

Hello Tim,

please consider the following patch which uses sqlplus from
ORACLE_HOME first, to figure out the client version:

--- DBD-Oracle-1.17/Makefile.PL 2005-12-28 23:09:52.000000000 +0100
+++ DBD-Oracle-1.17-patched/Makefile.PL 2005-12-29 21:09:27.000000000 +0100
@@ -1433,7 +1433,7 @@
     my $client_version_full = '';

     my $sqlplus_exe = ($os eq 'Win32' || $os eq 'MSWin32') ? "sqlplus.exe" : 
"sqlplus";
-    local $ENV{PATH} = join $Config{path_sep}, $ENV{PATH}, "$OH/bin", $OH;
+    local $ENV{PATH} = join $Config{path_sep}, "$OH/bin", $OH, $ENV{PATH};
     local $ENV{SQLPATH} = ""; # avoid $SQLPATH/login.sql causing sqlplus to 
hang
     print "path=$ENV{PATH}\n";
     if (find_bin($sqlplus_exe)) {

Without this patch, any random sqlplus from user's PATH will be used
instead of the sqlplus in $OH. In fact, 

        local $ENV{PATH} = join $Config{path_sep}, "$OH/bin", $OH;

might be even better, omitting $ENV{PATH} completely and just focusing
on the ORACLE_HOME directory.

Yours,

-- 
------------------------------------------------------------------------
 Honza Pazdziora | [EMAIL PROTECTED] | http://www.fi.muni.cz/~adelton/
 .project: Perl, mod_perl, DBI, Oracle, large Web systems, XML/XSL, ...
                Only self-confident people can be simple.

Reply via email to