On Tue, Mar 15, 2011 at 07:13:02PM +0000, Martin J. Evans wrote:
> >
> >Just call execute(1,2); # not enough args
> >check that that returns an error
> >and the errstr values don't contain ParamValues
> >and that $sth->{ParamValues} is empty.
> >
> I didn't do it quite like that mostly because errstr never contains
> ParamValues - only the PrintError and RaiseError msgs do. Attached
> patch p1 adds the test but you might want to look at the last test
> as it checks $sth->{ParamValues} is undef and until it is
> implemented I am unsure if you'll get an empty hashref or undef.
> This is committed. BTW, it needs Data::Dumper but I believe this is
> core and it is already used in other tests.
>
> Also, attached is patch p2 which just gets rid of some compiler
> warnings I got stick for in builds of DBD::ODBC. If it is ok with
> you I'll commit it - I don't see it does any harm but as it is in
> Driver.xst and has the potential to break all DBDs I thought I'd
> check.
Great. Thanks!
Tim.
