Excellent. Many thanks.
(I wasn't able to test on 5.5.3 before release as it no longer builds on FreeBSD.)
I'll make a new release soon.
Tim.
On Sat, Nov 30, 2002 at 03:34:09PM +0900, Tatsuhiko Miyagawa wrote:
> DBI 1.31 can't compile with perl 5.005_03. Patch applied. I know
> there's a plan to deprecate 5.005_03 in future DBI release, but at
> this time I can't find a documentation actually saying that.
>
> And some tweaks for DBI::Profile{Data,Dumper}.pm also applied.
>
> At Sat, 30 Nov 2002 01:04:23 +0000,
> Tim Bunce wrote:
> >
> > file: $CPAN/authors/id/T/TI/TIMB/DBI-1.31.tar.gz
> > size: 276605 bytes
> > md5: cd6d40e37ac2cad6db53e7dfbb1baf1c
>
>
> --
> Tatsuhiko Miyagawa <[EMAIL PROTECTED]>
>
>
> --- DBI.pm~ Sat Nov 30 08:57:09 2002
> +++ DBI.pm Sat Nov 30 15:19:48 2002
> @@ -514,7 +514,7 @@
> $user = '' if !defined $user;
> my $msg = "$class connect('$dsn','$user',...) failed: ".$drh->errstr;
> DBI->trace_msg(" $msg\n");
> - unless ($attr->{HandleError} && $attr->{HandleError}($msg, $drh, $dbh)) {
> + unless ($attr->{HandleError} && $attr->{HandleError}->($msg, $drh, $dbh)) {
> Carp::croak($msg) if $attr->{RaiseError};
> Carp::carp ($msg) if $attr->{PrintError};
> }
>
> --- lib/DBI/ProfileData.pm.orig Sat Nov 30 15:28:33 2002
> +++ lib/DBI/ProfileData.pm Sat Nov 30 15:30:25 2002
> @@ -75,6 +75,7 @@
> $VERSION = "1.0";
>
> use Carp qw(croak);
> +use Symbol;
>
> # some constants for use with node data arrays
> sub COUNT () { 0 };
> @@ -122,7 +123,8 @@
> my $read_header = 0;
>
> foreach my $filename (@$files) {
> - open(my $fh, $filename)
> + my $fh = gensym;
> + open($fh, $filename)
> or croak("Unable to read profile file '$filename': $!");
>
> $self->_read_header($fh, $filename, $read_header ? 0 : 1);
>
> --- lib/DBI/ProfileDumper.pm.orig Sat Nov 30 15:24:59 2002
> +++ lib/DBI/ProfileDumper.pm Sat Nov 30 15:26:12 2002
> @@ -158,6 +158,7 @@
> $VERSION = "1.0";
>
> use Carp qw(croak);
> +use Symbol;
>
> # validate params and setup default
> sub new {
> @@ -175,7 +176,7 @@
> my $self = shift;
> my $data = $self->{Data};
>
> - my $fh;
> + my $fh = gensym;
> if ($self->{_wrote_header}) {
> # append more data to the file
> open($fh, ">>$self->{File}")
