On delivery, every line is checked to see if it ends in \n or \r\n for the purposes of keeping an accurate rfcsize. The rfcsize is the size of the message with all newlines converted to \r\n. When the message goes out via IMAP, the newlines are supposed to be converted to \r\n. Nothing is modified before being stored in the database.
I can think of a few places where there might be \r insertion: Postfix while sending on LMTP (seems implausible, though), LMTP on receipt of the message (maybe I did something stupid like use '=' instead of '==' to check for \r\n) and IMAP on displaying the messages (that's where I'm gonna go looking :-P) Aaron Ilja Booij <[EMAIL PROTECTED]> said: > BTW, > > Everything is well when using dbmail-smtp (using pipe from postfix). > When using dbmail-lmtp, things get screwed up because lmtp already adds > '\r\n' instead of '\n' to every line. > > I'm getting a bit confused here.. :( > Are we trying to store messages using only '\n', or also using '\r\n', > or using only '\r\n'? > > I guess our messages parser should be robust enough to deal with both, > but apparantly it isn't. As I'm not terribly familiar with the parser > code, it'll take some time to fix this.. > > Ilja > > > Ilja Booij wrote: > > I think something goes wrong on insertion of messages. I have the > > feeling that an extra '\r' is included: > > > > I've made a small script that uses IMAP, and I get the following output: > > Received: by test01.office.fastxs.net (Postfix, from userid > > 1000)\r\r\n\tid A2BAA19F30C; Mon, 15 Mar 2004 14:05:48 +0100 > > (CET)\r\r\nTo: [EMAIL PROTECTED]: > > blaat\r\r\nMessage-Id: > > <[EMAIL PROTECTED]>\r\r\nDate: Mon, 15 > > Mar 2004 14:05:48 +0100 (CET)\r\r\nFrom: [EMAIL PROTECTED] > > (Ilja Booij)\r\r\n\r\r\n\r\r\n: blaat2\r\r\n: blaat3\r\r\n\r\n\x00' > > > > See all those extra '\r's? > > > > I'm now checking if these are also in the database, or that the extra > > '\r' is added by IMAP. > > > > Ilja > > > > > > Ilja Booij wrote: > > > >> I'm still working on the inclusion of the extra ':' in messages when > >> using IMAP. > >> > >> What I've found so far is that somehow the parser doesn't find the end > >> of the headers, and sees the beginning of the body as part of the > >> headers, and then includes the line in the body as a header line, > >> adding an empty key and ': ' like this: > >> > >> 'test' becomes ': test' > >> > >> I'm trying to find out why DBMail sees 'test' as part of the headers. > >> > >> IMHO, we cannot release dbmail rc4 before this is fixed > >> > >> Ilja > >> > >> > >> Aaron Stone wrote: > >> > >>> Looking at the list of bugs in 2.0rc3, I think we're in good shape > >>> for 2.0rc4: > >>> > >>> Before the final release of DBMail 2.0, there are some things > >>> we still need to resolve: > >>> - dbmail-lmtp has an error which sends it out of sync with the > >>> lmtp-client from the MTA after receiving more then 1 message > >>> > >>> Ilja figured out the parts of the LMTP RFC that I had misinterpreted, > >>> and I > >>> wrote the patches to fix it. > >>> > >>> - Connections with Mozilla are flakey > >>> > >>> Ilja figured this one out and fixed it; CVS has been working well for > >>> me. > >>> > >>> - Some database queries and indexes have to be optimized > >>> > >>> I just got rid of half a dozen queries during message insertion :-) > >>> > >>> - The MD5 calculation we use does not work on AMD Opteron systems > >>> > >>> Leif Jackson helped me to track down the wordsize and endianness > >>> problems. > >>> > >>> Was there anything else on anybody's mind that needed fixing? > >>> Especially given > >>> my changes in the delivery/sorting layer and Ilja's changes to IMAP, > >>> 2.0rc4 > >>> should probably go out pretty soon to get some more user testing! > >>> > >>> Aaron > >>> > >>> _______________________________________________ > >>> Dbmail-dev mailing list > >>> [email protected] > >>> http://twister.fastxs.net/mailman/listinfo/dbmail-dev > >> > >> > >> _______________________________________________ > >> Dbmail-dev mailing list > >> [email protected] > >> http://twister.fastxs.net/mailman/listinfo/dbmail-dev > > > > _______________________________________________ > > Dbmail-dev mailing list > > [email protected] > > http://twister.fastxs.net/mailman/listinfo/dbmail-dev > _______________________________________________ > Dbmail-dev mailing list > [email protected] > http://twister.fastxs.net/mailman/listinfo/dbmail-dev > --
