Ilja Booij wrote:
My trivial patch:

diff -r1.84 dbmysql.c
156a157
 >       /*
163a165,167
 >       */
 >       mysql_data_seek(res, row);
 >       last_row = mysql_fetch_row(res);

fixes the problem I've been having with _ic_list.

OK, I'll fix this and commit it.

Fixed and committed.

I took this code from earlier DBMail versions without thinking about it too much. So, we could just do a mysql_store_result(), and res will be set to NULL when appropriate (i.e. a after a query which returns no result)? Nice. This will make the function a lot simpler.

I guess we should do this then.

Done and committed


Btw, the testsuite now runs ok with the patch mentioned :-) So can we clean up dbmysql.c a little and move on ?

I guess so, I'll get to it.

Current CVS HEAD should work for you now. I guess we're finished with this. I'll take another look at the cleaning up code in imap4.c for the
SIGPIPE stuff.

Ilja

Reply via email to