On Sun, 2007-05-20 at 12:37 +0200, Paul J Stevens wrote:
> Aaron Stone wrote:
> > In dbmail-imapsession.c, dbmail_imap_session_get_msginfo, g_tree_keys
> > returns a GList that is not freed. That's the first two losses.
> 
> It is now.
> 
> > 
> > The third one is the self->fi->bodyfetch list. It *should* be freed from
> > dbmail_imap_session_delete, so perhaps we need to make sure that all
> > paths out of the imap server call that function.
> > 
> > I don't understand yet if that bodyfetch list needs to be kept for the
> > entire life of the connection or if we can flush it periodically. Paul
> > will have to advise about this.
> > 
> 
> It is only needed for the duration of a FETCH command. Will fix.

I found that dbmail_imap_session_resetFi appears to be called at the
right points after a FETCH command. But it was freeing the contents of
the self->fi->bodyfetch list, but not the contents of each element not
the list itself. I added a call to dbmail_imap_session_bodyfetch_free
which does all that. That much at least seemed to make the crucial
different for Peter.

Aaron

_______________________________________________
Dbmail-dev mailing list
Dbmail-dev@dbmail.org
http://twister.fastxs.net/mailman/listinfo/dbmail-dev

Reply via email to