On Fri, 2002-03-01 at 13:40, Petter Reinholdtsen wrote:
> - Avoid code duplication in main.c, and standardize how the messages
> catalog file is loaded. Allow the language code string to be a colon
> separated list.
> - Modify boxChooseLanguageVariant() accept a list of language codes
> - Change release_notes.c to use the same code path with and without
> the language chooser. Make it accept a list of language codes.
> - In util.c, allow a language list when choosing download host.
> - in norwegian.src, demonstrate how this new list should be used for
> Norwegian bokmål and nynorsk.
In principle this is fine, but the changes to main.c and release_notes.c
are sufficiently inscrutable at a casual reading to make me a bit
nervous.
Would you mind sending a patch that contains only the changes necessary
for multiple language code handling, without any reorganisation of the
rest of the code? I think that would make it easier for people to
review.
+ if ( LOAD_TRMFILE("/etc/messages.en") != 0 ||
+ LOAD_TRMFILE("/etc/messages.trm") != 0 ||
+ LOAD_TRMFILE(TRMBACKUP) != 0 )
That doesn't look quite right to me.
p.
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
