-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Frans Pop wrote: > On Thursday 21 December 2006 18:36, Eddy Petrișor wrote: >> The reason I placed it in there was that it seemed the most appropriate >> place since that is finish-install info. Do you think that >> /usr/lib/ppp-udeb/ is a better place? >> >> If the fact that the script is in /usr/lib/finish-install.d/ is the >> problem, of course, this can be changed, since the script is harmless, >> I didn't thought it would be a problem. > > <eddyp> fjp: I have sent an email about that sourced script > <eddyp> I wasn't sure either which was the best way > <eddyp> if the sourced "script" is not +x is that ok? or do you prefer > the /usr/lib/ppp-udeb/solution? > <eddyp> s:ppp-udeb/:ppp-udeb/ : > <fjp> finish-install.d should only contain actual scripts that should be > run during finish-install, and nothing else. > > Note that what you were putting into finish-install.d is _not_ a script... > > <eddyp> fjp: as I said in the mail, the script is harmless ... that's why > I thought it would be fine > <fjp> Why don't you set that value in debconf, if you need to retrieve it > later? > <fjp> eddyp: Dumping cruft in a runparts directory is never OK. > <eddyp> finish-install.d has debconf available? > <fjp> Of course. > <eddyp> I wasn't aware of that > <eddyp> ok, that is nice > <fjp> Look at other scripts in finish-install.d...
done and attached In order to have an upload I think it would be sane to merge also the changes in the 2.4.4rel-4.1 NMU. Will prepare that and will send an update. (If anyone cares, my ppp darcs repo is available at: http://users.alioth.debian.org/~eddyp-guest/darcs/ppp/) - -- Regards, EddyP ============================================= "Imagination is more important than knowledge" A.Einstein -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFFis0eY8Chqv3NRNoRAtN2AJ4klRmtgxnfDM8rECvERsEDqqkVYgCcD56O WTMDp+4Nnfuv0PLk5huNdWQ= =amcr -----END PGP SIGNATURE-----
--- old-ppp-eddyp-dev/ppp-2.4.4rel/debian/changelog 2006-12-21 20:00:50.000000000 +0200 +++ new-ppp-eddyp-dev/ppp-2.4.4rel/debian/changelog 2006-12-21 20:00:50.000000000 +0200 @@ -1,3 +1,16 @@ +ppp (2.4.4rel-5~) unstable; urgency=low + + [ Eddy PetriÈor ] + * added ${misc:Depends} to ppp-udeb + * removed debconf as a dependency of ppp-udeb since such a package does not + exist in d-i environment + * ppp-udeb: the interface is now raised in the installed system + (Closes: #402450) + * ppp-udeb: loopback interface snippet is added too, to make sure we have it + in the installed system + + -- Eddy PetriÈor <[EMAIL PROTECTED]> Thu, 21 Dec 2006 19:57:12 +0200 + ppp (2.4.4rel-4) unstable; urgency=low [ Eddy PetriÈor ] diff -rN -u old-ppp-eddyp-dev/ppp-2.4.4rel/debian/control new-ppp-eddyp-dev/ppp-2.4.4rel/debian/control --- old-ppp-eddyp-dev/ppp-2.4.4rel/debian/control 2006-12-21 20:00:50.000000000 +0200 +++ new-ppp-eddyp-dev/ppp-2.4.4rel/debian/control 2006-12-21 20:00:50.000000000 +0200 @@ -23,7 +23,7 @@ XC-Package-Type: udeb Section: debian-installer Architecture: any -Depends: ${shlibs:Depends}, ethernet-card-detection, ppp-modules, di-utils, debconf +Depends: ${shlibs:Depends}, ${misc:Depends}, ethernet-card-detection, ppp-modules, di-utils Provides: configured-network XB-Installer-Menu-Item: 17 Description: Point-to-Point Protocol (PPP) daemon diff -rN -u old-ppp-eddyp-dev/ppp-2.4.4rel/extra/50config-target-ppp new-ppp-eddyp-dev/ppp-2.4.4rel/extra/50config-target-ppp --- old-ppp-eddyp-dev/ppp-2.4.4rel/extra/50config-target-ppp 2006-12-21 20:00:50.000000000 +0200 +++ new-ppp-eddyp-dev/ppp-2.4.4rel/extra/50config-target-ppp 2006-12-21 20:00:50.000000000 +0200 @@ -1,6 +1,28 @@ #!/bin/sh -e # Copy the ppp configuration to the target system. +. /usr/share/debconf/confmodule + mkdir -p /target/etc/ppp cp /etc/ppp/*-secrets /target/etc/ppp/ cp -a /etc/ppp/peers /target/etc/ppp/ + +db_get ppp/interface +ETH="$RET" +mkdir -p /target/etc/network/ +# FIXME: lo snippet should not be ppp-udeb's job +cat >> /target/etc/network/interfaces <<EOPPP + +# PPPoE configuration +# added by Debian Installer +auto lo +iface lo inet loopback + +auto provider +iface provider inet ppp + pre-up /sbin/ifconfig $ETH up + provider provider +# end of PPPoE configuration + +EOPPP +