Your message dated Mon, 6 Jun 2005 03:27:28 -0700
with message-id <[EMAIL PROTECTED]>
and subject line samba bugs reported against woody
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 8 Aug 2002 20:52:44 +0000
>From [EMAIL PROTECTED] Thu Aug 08 15:52:44 2002
Return-path: <[EMAIL PROTECTED]>
Received: from gnu.in-berlin.de [192.109.42.4]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 17cuGy-0007dA-00; Thu, 08 Aug 2002 15:52:44 -0500
Received: from cella.kloster.be.schule.de ([EMAIL PROTECTED] [212.42.253.35])
by gnu.in-berlin.de (8.12.1/8.12.1/Debian -5) with ESMTP id
g78Kqfxd009275;
Thu, 8 Aug 2002 22:52:41 +0200
Received: from mkarcher by cella.kloster.be.schule.de with local (Exim 3.35 #1
(Debian))
id 17cuGu-0006rI-00; Thu, 08 Aug 2002 22:52:40 +0200
Date: Thu, 8 Aug 2002 22:52:40 +0200
From: Michael Karcher <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: libpam-smbpass: libpam_smbpass damages SIGALRM setting
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Reportbug-Version: 1.50
X-Debbugs-Cc: [EMAIL PROTECTED]
Delivered-To: [EMAIL PROTECTED]
Package: libpam-smbpass
Version: 2.2.3a-6.0.1
Severity: important
Tags: patch
Hi developers,
The function in the samba library to lock files uses alarm to implement
a timeout on locking, but fails to return the previous setting
afterwards. Instead it switches the signal back to SIG_DFL. While this
may be OK for samba code, because SIGALRM is not used otherwise in
there, it renders programs useless that use libpam_smbpass to migrate to
encrypted smb passwords, if they use sigalarm themselves. An example for
this is afpd from the netatalk package. It implements a keepalive using
setitimer. After using libpam_smbpass, that reset SIGALRM, instead of
doing keepalives after 30 seconds(!) of idle time, the process dies.
Because this would be an at least important bug in afpd, I used the
priority important here. Downgrade if you wish.
The attached patch is not all to do. Because it adds to functions to the
samba utility collection source/include/proto.h must be updated too. I
did it quick and dirty hack to get the fix compile here, but someone
with a clue on samba, especially its packaging and the patches should
do the right thing(TM).
Don't scream about the debian revision 6.0.1 of the package. I know it
is not in the archive. This is just the name of the fixed package I
already installed.
Thanks, Michael Karcher
--- samba-2.2.3a.orig/source/lib/signal.c
+++ samba-2.2.3a/source/lib/signal.c
@@ -121,6 +121,33 @@
#endif
}
+void * SaveSignal(int signum)
+{
+#ifdef HAVE_SIGACTION
+ struct sigaction * old;
+ old = malloc(sizeof *old);
+ sigaction(signum,NULL,old);
+ return old;
+#else
+ void (**handler)();
+ handler = malloc(sizeof *old);
+ BlockSignals(1,signum);
+ *handler = signal(signum,SIG_IGN);
+ signal(signum,*handler);
+ return handler;
+#endif
+}
+
+void RestoreSignal(int signum, void * old)
+{
+#ifdef HAVE_SIGACTION
+ sigaction(signum,(struct sigaction*) old,NULL);
+#else
+ signal(signum,*(void (**handler)())old);
+#endif
+ free(old);
+}
+
/*******************************************************************
Ignore SIGCLD via whatever means is necessary for this OS.
********************************************************************/
--- samba-2.2.3a.orig/source/lib/util_file.c
+++ samba-2.2.3a/source/lib/util_file.c
@@ -39,8 +39,10 @@
{
SMB_STRUCT_FLOCK lock;
int ret;
+ void* oldalarm;
gotalarm = 0;
+ oldalarm = SaveSignal(SIGALRM);
CatchSignal(SIGALRM, SIGNAL_CAST gotalarm_sig);
lock.l_type = type;
@@ -52,7 +54,7 @@
alarm(waitsecs);
ret = fcntl(fd, SMB_F_SETLKW, &lock);
alarm(0);
- CatchSignal(SIGALRM, SIGNAL_CAST SIG_DFL);
+ RestoreSignal(SIGALRM,oldalarm);
if (gotalarm) {
DEBUG(0, ("do_file_lock: failed to %s file.\n",
-- System Information
Debian Release: 3.0
Architecture: i386
Kernel: Linux cella 2.4.19 #1 Die Aug 6 14:14:06 CEST 2002 i686
Locale: LANG=de_DE, LC_CTYPE=de_DE
Versions of packages libpam-smbpass depends on:
ii libc6 2.2.5-10 GNU C Library: Shared libraries an
ii libcupsys2 1.1.14-3 Common UNIX Printing System(tm) -
ii libpam0g 0.72-35 Pluggable Authentication Modules l
---------------------------------------
Received: (at 155978-done) by bugs.debian.org; 6 Jun 2005 10:27:29 +0000
>From [EMAIL PROTECTED] Mon Jun 06 03:27:28 2005
Return-path: <[EMAIL PROTECTED]>
Received: from dsl093-039-086.pdx1.dsl.speakeasy.net (mauritius.dodds.net)
[66.93.39.86]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1DfEpM-0005E7-00; Mon, 06 Jun 2005 03:27:28 -0700
Received: by mauritius.dodds.net (Postfix, from userid 1000)
id 6895F171E36; Mon, 6 Jun 2005 03:27:28 -0700 (PDT)
Date: Mon, 6 Jun 2005 03:27:28 -0700
From: Steve Langasek <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED], [EMAIL PROTECTED],
[EMAIL PROTECTED]
Subject: samba bugs reported against woody
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="1rguoi8KZGYj2k4L"
Content-Disposition: inline
User-Agent: Mutt/1.5.9i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-2.0 required=4.0 tests=BAYES_00,SORTED_RECIPS
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
X-CrossAssassin-Score: 2
--1rguoi8KZGYj2k4L
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
These bugs were reported against the version of samba in woody. As of this
week, the stable release of Debian will be sarge; if you are still
experiencing any of these bugs with woody, please upgrade to sarge, as they
are all believed to be fixed in this new stable version of Debian.
Thanks,
--=20
Steve Langasek
postmodern programmer
--1rguoi8KZGYj2k4L
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFCpCUPKN6ufymYLloRAgxrAKCC+1B8cZh3CtNhP7Yw9TLAmwFBDwCg0S8T
0gCBCeZbf7ugOhjtblT+Lhw=
=4Swb
-----END PGP SIGNATURE-----
--1rguoi8KZGYj2k4L--
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
