Your message dated Wed, 26 Nov 2008 18:47:04 +0000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#487939: fixed in mdp 2.4+svn20081126-1
has caused the Debian Bug report #487939,
regarding python-mdp: ICA nodes do not pass params to WhiteningNode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [EMAIL PROTECTED]
immediately.)


-- 
487939: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=487939
Debian Bug Tracking System
Contact [EMAIL PROTECTED] with problems
--- Begin Message ---
Package: python-mdp
Version: 2.3+svn20080515-2
Severity: normal
Tags: patch


Hi,

This version of MDP does not allow ICANodes to send params to the
WhiteningNode they use internally. Although, both documentation and API
indicate that it is supposed to work.

The reason is, that the ICANode constructor ignores its own argument
'white_parm'.

Please find the attached patch, which fixes the problem. It also changes
the default value of this argument to 'None' instead of '{}', as the
former has probably unintended sideeffects:

http://www.python.org/doc/2.1.3/tut/node6.html#SECTION006710000000000000000
(from 'Important warning:' on ;-)



Thanks,

Michael



-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)

Kernel: Linux 2.6.24-1-686 (SMP w/1 CPU core)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages python-mdp depends on:
ii  python                        2.5.2-1    An interactive high-level object-o
ii  python-numpy                  1:1.1.0-1  Numerical Python adds a fast array
ii  python-support                0.7.6      automated rebuilding support for p

Versions of packages python-mdp recommends:
ii  python-symeig                 1.4-2      Symmetrical eigenvalue routines fo

-- no debconf information

-- 
GPG key:  1024D/3144BE0F Michael Hanke
http://apsy.gse.uni-magdeburg.de/hanke
ICQ: 48230050
diff -rNu mdp-2.3+svn20080515.orig/mdp/nodes/ica_nodes.py mdp-2.3+svn20080515/mdp/nodes/ica_nodes.py
--- mdp-2.3+svn20080515.orig/mdp/nodes/ica_nodes.py	2008-05-15 20:28:28.000000000 +0200
+++ mdp-2.3+svn20080515/mdp/nodes/ica_nodes.py	2008-06-25 11:37:43.000000000 +0200
@@ -42,7 +42,7 @@
     """
     
     def __init__(self, limit = 0.001, telescope = False, verbose = False,
-                 whitened = False, white_comp = None, white_parm = {},
+                 whitened = False, white_comp = None, white_parm = None,
                  input_dim = None, dtype = None):
         """
         Input arguments:
@@ -72,7 +72,10 @@
         self.limit = limit
         self.whitened = whitened
         self.white_comp = white_comp
-        self.white_parm = {}
+        if not white_parm is None:
+            self.white_parm = white_parm
+        else:
+            self.white_parm = {}
         super(ICANode, self).__init__(input_dim, None, dtype)
 
 
@@ -325,7 +328,7 @@
                  sample_size = 1, fine_tanh = 1, fine_gaus = 1,
                  max_it = 1000, max_it_fine = 100, 
                  failures = 5, limit = 0.001, verbose = False,
-                 whitened = False, white_comp = None, white_parm = {},
+                 whitened = False, white_comp = None, white_parm = None,
                  input_dim = None, dtype=None):
         """
         Input arguments:
@@ -935,7 +938,7 @@
     """
     def __init__(self, lags=1, limit = 0.00001, max_iter=10000,
                  verbose = False, whitened = False, white_comp = None,
-                 white_parm = {}, input_dim = None, dtype = None):
+                 white_parm = None, input_dim = None, dtype = None):
         """
         Input arguments:
 
@@ -966,7 +969,7 @@
         super(TDSEPNode, self).__init__(lags=lags, sfa_ica_coeff=[0.,1.],
                                        icaweights=None, sfaweights=None,
                                        whitened=whitened,white_comp=white_comp,
-                                       white_parm = {},
+                                       white_parm = None,
                                        eps_contrast=limit,
                                        max_iter=max_iter, RP=None,
                                        verbose=verbose, 

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: mdp
Source-Version: 2.4+svn20081126-1

We believe that the bug you reported is fixed in the latest version of
mdp, which is due to be installed in the Debian FTP archive:

mdp_2.4+svn20081126-1.diff.gz
  to pool/main/m/mdp/mdp_2.4+svn20081126-1.diff.gz
mdp_2.4+svn20081126-1.dsc
  to pool/main/m/mdp/mdp_2.4+svn20081126-1.dsc
mdp_2.4+svn20081126.orig.tar.gz
  to pool/main/m/mdp/mdp_2.4+svn20081126.orig.tar.gz
python-mdp_2.4+svn20081126-1_all.deb
  to pool/main/m/mdp/python-mdp_2.4+svn20081126-1_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Yaroslav Halchenko <[EMAIL PROTECTED]> (supplier of updated mdp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Tue, 28 Oct 2008 13:48:02 -0400
Source: mdp
Binary: python-mdp
Architecture: source all
Version: 2.4+svn20081126-1
Distribution: unstable
Urgency: low
Maintainer: Yaroslav Halchenko <[EMAIL PROTECTED]>
Changed-By: Yaroslav Halchenko <[EMAIL PROTECTED]>
Description: 
 python-mdp - Modular toolkit for Data Processing
Closes: 487939
Changes: 
 mdp (2.4+svn20081126-1) unstable; urgency=low
 .
   * New Upstream Upstream Version + SVN snapshot since (Closes: #487939)
   * Suggests python-pp (tandem with pp is still alpha/unstable, thus only
     in suggests)
Checksums-Sha1: 
 8d6bd8bd493029b18bc14055a2fcf23f21d305cd 1206 mdp_2.4+svn20081126-1.dsc
 9b2a4e6a776b594da66d77e08f2cd23c1a72379c 164012 mdp_2.4+svn20081126.orig.tar.gz
 94d44935a0e6ffeb02efea9752c168e1ab0ba53d 2800 mdp_2.4+svn20081126-1.diff.gz
 5e3627d60a1cf0f9a4e2cbc61283ddb2a504056c 152836 
python-mdp_2.4+svn20081126-1_all.deb
Checksums-Sha256: 
 e288e33b8e42a9d4a974fb2e2fb74f8416db03fc1125413b197e4e052db1e781 1206 
mdp_2.4+svn20081126-1.dsc
 d1df22df6fd87303174ccade8e40a71f762361f99a24232a362a516543c3ffaf 164012 
mdp_2.4+svn20081126.orig.tar.gz
 3545ae42a10ae428bf3f2944c8a29cd82f0574fc583c72670c34f65257b6ed7f 2800 
mdp_2.4+svn20081126-1.diff.gz
 a96f7ce0e88a1fc27d19a6b43381f08bb92ee0e7ec4caa49a47986d304860121 152836 
python-mdp_2.4+svn20081126-1_all.deb
Files: 
 cc5f9306e738a2c7f860ae36d3dfad3a 1206 python optional mdp_2.4+svn20081126-1.dsc
 4721ccf72e7633b1b58680fd5c32944a 164012 python optional 
mdp_2.4+svn20081126.orig.tar.gz
 8423e11451884f6a7d9d698ec6d20fdd 2800 python optional 
mdp_2.4+svn20081126-1.diff.gz
 b751c5369ddc0a49120ed03c9e3d5bb0 152836 python optional 
python-mdp_2.4+svn20081126-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)

iEYEARECAAYFAkktlzkACgkQjRFFY3XAJMjxdACgn0I9p9NqlU07OQKhCgoPOoSL
sNsAnR3ghwKkZBqstbYJbcHAVj1Jo6EQ
=T2ui
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to