Your message dated Wed, 7 Jul 2010 21:55:33 +0900 with message-id <[email protected]> and subject line Re: Bug#588296: example quiltrc in 3.1 doesn't set QUILT_PATCHES correctly has caused the Debian Bug report #588296, regarding example quiltrc in 3.1 doesn't set QUILT_PATCHES correctly to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 588296: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=588296 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: maint-guide Version: 1.2.19 Severity: normal Tags: patch Hello, In section 3.1 there's a nifty example ~/.quiltrc for determining if you're in the tree of a debian package and then setting the quilt options appropriately. However, the QUILT_PATCHES is then set incorrectly; the corrected line 4 should read: QUILT_PATCHES="$d/debian/patches" Note that the original is missing the leading '$d/' and the surrounding double-quotes (in case $d contains spaces). Thanks for the great documentation. --Joe -- System Information: Debian Release: squeeze/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'stable'), (1, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.32-5-686 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash maint-guide depends on no packages. maint-guide recommends no packages. Versions of packages maint-guide suggests: ii debian-policy 3.9.0.0 Debian Policy Manual and related d ii developers-reference 3.4.3 guidelines and information for Deb ii devscripts 2.10.64 scripts to make the life of a Debi ii dh-make 0.55 tool that converts source archives ii doc-base 0.9.5 utilities to manage online documen ii dupload 2.6.6 utility to upload Debian packages ii fakeroot 1.14.4-1 Gives a fake root environment ii lintian 2.4.2 Debian package checker ii pbuilder 0.199 personal package builder for Debia ii quilt 0.48-7 Tool to work with series of patche -- no debconf information
--- End Message ---
--- Begin Message ---On Tue, Jul 06, 2010 at 09:19:19PM -0400, Joseph Nahmias wrote: > Package: maint-guide > Version: 1.2.19 > Severity: normal > Tags: patch > > Hello, Thanks for your inters. But I am closing this bug based on: * it works. * it matches with documented way to set value. * I do not find any bug here. See below and , if I made any mistake, please do not hesitate to reopen this but clearly state what problem you faced and how your proposal helps. > In section 3.1 there's a nifty example ~/.quiltrc for determining if > you're in the tree of a debian package and then setting the quilt options > appropriately. However, the QUILT_PATCHES is then set incorrectly; the > corrected line 4 should read: > > QUILT_PATCHES="$d/debian/patches" This makes sense if this value QUILT_PATCHES points to patch directory. But is this true? What is your basis for this assertion? > Note that the original is missing the leading '$d/' and the surrounding > double-quotes (in case $d contains spaces). > > Thanks for the great documentation. > --Joe But the following is working for me now for a while. d=. ; while [ ! -d "$d/debian" -a `readlink -e $d` != / ]; do d="$d/.."; done if [ -d "$d/debian" ] && [ -z "$QUILT_PATCHES" ]; then # Debian packaging case and unset $QUILT_PATCHES QUILT_PATCHES=debian/patches QUILT_PATCH_OPTS="--unified-reject-files" QUILT_DIFF_ARGS="-p ab --no-timestamps --no-index --color=auto" QUILT_REFRESH_ARGS="-p ab --no-timestamps --no-index" QUILT_COLORS="diff_hdr=1;32:diff_add=1;34:diff_rem=1;31:diff_hunk=1;33:diff_ctx=35:diff_cctx=33" if ! [ -d $d/debian/patches ]; then mkdir $d/debian/patches; fi fi Did you face real issue with the configuration? Or are you judging fro how it looks? I see following in manpage: QUILT_PATCHES The location of patch files, defaulting to "patches". Since we are moving this from "patches" to "debian/patches", what we are doing seems right. Osamu
--- End Message ---
