Your message dated Fri, 10 Jun 2011 17:32:09 +0000
with message-id <[email protected]>
and subject line Bug#583093: fixed in dump 0.4b44-1
has caused the Debian Bug report #583093,
regarding restore -P creates useless index for compressed dumps
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
583093: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=583093
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dump
Version: 0.4b41-6
Severity: normal
Tags: patch


To reproduce: make a compressed dump of a filesystem:

        # dump -0 -fdump -z /var
        [...]

Now generate a QFA index:

        $ restore -Pqfa -fdump -v -a
        Verify tape and initialize maps
        Input is from a local file/pipe
        Input block size is 10
        Dump tape is compressed.
        Dump   date: Mon May 24 21:42:31 2010
        Dumped from: the epoch
        Level 0 dump of /var on metalzone:/dev/mapper/vg-var
        Label: var
        writing QFA positions to qfa2
        Extract directories from tape
        Initialize symbol table.
        Extract requested files

Inspect the `qfa' file; notice that the `tapepos' column only contains
zero.

Digging through the source code, I think that the functions
`readtape_comprfile' and `readtape_comprtape' are missing the `#ifdef
USE_QFA' snippet which was added to `readtape_uncompr'.

The following patch appears to work, but I'm really not particularly
confident in my understanding of the `restore' source and I've only
conducted superficial testing (I haven't tested the `comprtape' code-
path at all, because I don't have a tape drive).

diff --git a/restore/tape.c b/restore/tape.c
index c74e390..2696b1d 100644
--- a/restore/tape.c
+++ b/restore/tape.c
@@ -2068,6 +2068,10 @@ readtape_comprfile(char *buf)
                ((struct s_spcl *)&tapebuf[i * TP_BSIZE])->c_magic = 0;
        numtrec = ntrec;
        tpb = (struct tapebuf *) tapebuf;
+#ifdef USE_QFA
+       if (createtapeposflag)
+               (void)GetTapePos(&curtapepos);
+#endif
 
        /* read the block prefix */
        ret = read_a_block(mt, tapebuf, PREFIXSIZE, &rl);
@@ -2157,6 +2161,10 @@ readtape_comprtape(char *buf)
                ((struct s_spcl *)&tapebuf[i * TP_BSIZE])->c_magic = 0;
        numtrec = ntrec;
        tpb = (struct tapebuf *) tapebuf;
+#ifdef USE_QFA
+       if (createtapeposflag)
+               (void)GetTapePos(&curtapepos);
+#endif
 
        /* read the block */
        size = bufsize + PREFIXSIZE;


-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.31.9 (PREEMPT)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages dump depends on:
ii  e2fslibs                  1.41.11-1      ext2/ext3/ext4 file system librari
ii  libblkid1                 2.16.2-0       block device id library
ii  libc6                     2.10.2-6       Embedded GNU C Library: Shared lib
ii  libcomerr2                1.41.11-1      common error description library
ii  libncurses5               5.7+20100313-2 shared libraries for terminal hand
ii  libreadline5              5.2-7          GNU readline and history libraries
ii  libuuid1                  2.16.2-0       Universally Unique ID library
ii  tar                       1.23-1         GNU version of the tar archiving u

dump recommends no packages.

dump suggests no packages.

-- debconf information:
  dump/dumpdates_is_a_symlink:
  dump/moving_from_etc_to_var:



--- End Message ---
--- Begin Message ---
Source: dump
Source-Version: 0.4b44-1

We believe that the bug you reported is fixed in the latest version of
dump, which is due to be installed in the Debian FTP archive:

dump_0.4b44-1.debian.tar.gz
  to main/d/dump/dump_0.4b44-1.debian.tar.gz
dump_0.4b44-1.dsc
  to main/d/dump/dump_0.4b44-1.dsc
dump_0.4b44-1_i386.deb
  to main/d/dump/dump_0.4b44-1_i386.deb
dump_0.4b44.orig.tar.gz
  to main/d/dump/dump_0.4b44.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Bdale Garbee <[email protected]> (supplier of updated dump package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 10 Jun 2011 11:06:30 -0600
Source: dump
Binary: dump
Architecture: source i386
Version: 0.4b44-1
Distribution: unstable
Urgency: low
Maintainer: Bdale Garbee <[email protected]>
Changed-By: Bdale Garbee <[email protected]>
Description: 
 dump       - 4.4bsd dump and restore for ext2 filesystems
Closes: 583093 614068 622350 629831
Changes: 
 dump (0.4b44-1) unstable; urgency=low
 .
   * new upstream version, closes: #583093, #614068, #622350, #629831
   * add pkg-config as a build dependency
   * update to newer source package format
   * work around com_err not showing up in EXT2FS_LIBS with pass to configure
   * update lintian overrides related to static linking of compression libs
   * add Vcs entries to the control file
Checksums-Sha1: 
 333600733d3322f0e886847ec9af7a3fb65311e0 1830 dump_0.4b44-1.dsc
 9bef0f86095a9214045b44f5c78efa3fbebcfc58 296691 dump_0.4b44.orig.tar.gz
 0a184a8bf457191c1296df1591e7b37c4e04f145 10423 dump_0.4b44-1.debian.tar.gz
 eafb0b7d62f1b15747ab1f62155aba05580c4fe1 269272 dump_0.4b44-1_i386.deb
Checksums-Sha256: 
 4ad1ea5f7f7e22803801c50ef754d3c98a315bd63b4a11f3e595aaf78820bb92 1830 
dump_0.4b44-1.dsc
 78cb75632ac5e99dca38af3a2574303eee3c5a7af464011d279421d8b0e64f96 296691 
dump_0.4b44.orig.tar.gz
 898884ee8f9ad978c368d5858b89de1649d3479ee26e07ee95fc15fc2caec505 10423 
dump_0.4b44-1.debian.tar.gz
 5ff4e3ef98bcff24363de1b4f0b5727a4343e5efcd350f1185cdeff7947b19f3 269272 
dump_0.4b44-1_i386.deb
Files: 
 48d89d27c68c6e5719c57b582d704938 1830 utils optional dump_0.4b44-1.dsc
 daec97b1ad905c904eba926221f4be6d 296691 utils optional dump_0.4b44.orig.tar.gz
 ad9c1ffab5c0e4c4e806735d9b45f5d1 10423 utils optional 
dump_0.4b44-1.debian.tar.gz
 7b699ff20bb31db7d49f44a9862c6ff7 269272 utils optional dump_0.4b44-1_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIVAwUBTfJTajqTYZbAldlBAQqrZQ/+L3PlrZ+3KxYCXoP/LP/xlkfgzsNjxuhs
O5mZk9JBbfCFUnzTp30DgivuJ5Qf4VhwzjfQWM0UDepfATLaxz0PD6USnqsrmFEW
eh9utc4k4G/Wr+7atT6AOT3oxQy6rGQ52Y4MKyBJw7pJEcAn7nw+i8sUn4RHND3Y
CNt2U6H0d38PkcKEA+leEjze+zrrbOqTjMcoXczYmOG4X8fSyeDfvSs8a1UtTTHU
DWZY0zLXO1GseY05yO1/CWBLn22ToIwTq+fzHArUKNLuDNIqdNgae9VMcdExoGll
0nW8o55wYit7uzxTJzKBpe4VC9NJCwA9B8iyC91wY8RJus9X8+9zEY16M9ujfA/t
NXvWQ36bJwqSESauCuaBrZL8jW/k/6OJyL2Rog6QOQlIn9k8Or2TagiSwlvxPNDW
nKxl4vmymFcCEZbUm3rDmCb45Mt1MVaZ78SxwKRa2Zh/iZqAZ9sV4tfEd0GeqxmQ
Z2+Bt8pSNa+46Kd6NaJmECszaZYIqwqJ7AZHt/Ym2S406vy5fyQoewfOIKlt8Yb3
4npWDXPjMN1j4q2ndeL+gBZprJ+NCAQx9HBhurXRqJ0K/b28OLYb6H3fSIYKtTI3
iptIibVYylMdgXngdbwuTTn7cA65L29G6M5788IH5ra9/5rOzEfbE5NusP59qXUW
H/rBNTG3aaA=
=1+ky
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to